New components [#217271]

Attached is a patch that would add several new components:

1) Sequences

2) Storage

Sequences work like this: they replace some given text with a number given by a function. The sequence component itself keeps track of the numbereth time in the sequence: starting at 0, going up by one each time. It then passes that number into a function selected by the user, which had been previously registered through an implementation of hook_flexifilter_sequences. Included in this are basic numbers, lower case letters, and upper case letters.

There are two storage components, a set and a get. The set component sets one variable slot to the current text as run through a set of components set in the settings. The get component gets the variable set previously in one of the variable slots, runs it through a set of components set in the settings, and returns it.

Comment	File	Size	Author
	flexifilter_components_sequences_and_storage_01.patch	5.18 KB	cwgordon7

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

corsix CreditAttribution: corsix commented 3 February 2008 at 12:31

Status:

Needs review

» Needs work

I don't think you totally understand static variables:

 +function flexifilter_component_storage_set($op, $settings, $text) {
+  switch ($op) {
+    case 'settings':
+      return flexifilter_storage_slot();
+
+    case 'prepare':
+    case 'process':
+      $data = flexifilter_invoke_components($settings['components'], $op, $text);
+	  static $_flexifilter_stored_data = array();

 +function flexifilter_component_storage_get($op, $settings, $text) {
+  switch ($op) {
+    case 'settings':
+      $form = flexifilter_storage_slot();
+
+    case 'prepare':
+    case 'process':
+      static $_flexifilter_stored_data = array();

Static variables are just like local variables, only they are persistent across calls to the function. Giving static variables within two different functions the same name does not cause them to be the same variable. Hence, doing a storage get will always be blank, as the storage set was stored in a different variable.

Comment #2

cwgordon7 CreditAttribution: cwgordon7 commented 3 February 2008 at 22:18

Sequences committed; storage needs work.

Comment #3

apaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

CreditAttribution: apaderno commented 15 November 2008 at 23:38

It's enough to change the code to:

function flexifilter_component_storage_set($op, $settings, $text) {
  switch ($op) {
    case 'settings':
      return flexifilter_storage_slot();

    case 'prepare':
    case 'process':
      $data = flexifilter_invoke_components($settings['components'], $op, $text);
      $stored_data = flexifilter_get_stored_data();
      $stored_data[$settings['slot']] = $data;
      return $text;
  }
}

/**
 * Component callback.
 */
function flexifilter_component_storage_get($op, $settings, $text) {
  switch ($op) {
    case 'settings':
      $form = flexifilter_storage_slot();

    case 'prepare':
    case 'process':
      $stored_data = flexifilter_get_stored_data();
      if (!isset($stored_data[$settings['slot']])) {
        $stored_data[$settings['slot']] = '';
      }
      $data = flexifilter_invoke_components($settings['components'], $op, $_flexifilter_stored_data[$settings['slot']]);
      return $data;
  }
}

function &flexifilter_get_stored_data() {
  static $data;
  
  return $data;
}