Right now Drupal commerce assigns the Alpha theme container tags inside of the Commerce Kickstart Product UI module included in Drupal Commerce. As this is a theming function, shouldn't this be placed in the theme?? If it has to be placed in this module shouldn't there be a way of changing this from the UI instead of having to alter the code of a module??

Comments

lsolesen’s picture

Issue tags: -themeing

So exactly what code do you want to move

lsolesen’s picture

Status: Active » Postponed (maintainer needs more info)
mglaman’s picture

Status: Postponed (maintainer needs more info) » Closed (won't fix)

Marking won't fix. Over a year and no clarification.

mglaman’s picture

Status: Closed (won't fix) » Active

Nevermind, found what is being discussed

node--product--type.tpl.php

<article<?php print $attributes; ?>>
  <?php print $user_picture; ?>
  <?php print render($title_prefix); ?>
  <?php if (!$page && $title): ?>
  <header>
    <h2<?php print $title_attributes; ?>><a href="<?php print $node_url ?>" title="<?php print $title ?>"><?php print $title ?></a></h2>
  </header>
  <?php endif; ?>
  <?php print render($title_suffix); ?>
  <?php if ($display_submitted): ?>
  <footer class="submitted"><?php print $date; ?> -- <?php print $name; ?></footer>
  <?php endif; ?>
  <div class="container-24 grid-14 prefix-1 clearfix">
    <?php print render($content['product:field_images']); ?>
  </div>
  <div class="container-24 grid-8 prefix-1">
    <div<?php print $content_attributes; ?>>
      <?php
        // We hide the comments and links now so that we can render them later.
        hide($content['comments']);
        hide($content['links']);
        print render($content);
      ?>
    </div>
  </div>
  <div class="container-24 grid-24 clearfix">
    <?php if (!empty($content['links'])): ?>
    <nav class="links node-links clearfix"><?php print render($content['links']); ?></nav>
    <?php endif; ?>
    <?php
    print render($content['comments']);
    ?>
  </div>
</article>

This probably should be moved to omega_kickstart itself, not the module.

mglaman’s picture

Issue tags: +sprint
lsolesen’s picture

There is a lot of theming functions in commerce_kickstart_product_ui/theme. Which ones should be moved to the theme layer?

rszrama’s picture

Status: Active » Closed (outdated)

Commerce Kickstart 2.x is in minimal maintenance mode. Closing out all outdated tickets now to maintain focus on Commerce Kickstart 3.x.