Updated: Comment #0

Problem/Motivation

#1862202: Objectify the language system moved most of the language negotiation code to classes. Configuration code for language negotiation plugins, which is rarely used, was held back to limit the size of the patch.

Proposed resolution

  1. Remove language_negotiation_url_* functions and just inject the config-factory into the settings form.
  2. Remove language_[g|s]et_browser_drupal_langcode_mappings() functions
  3. Move language_get_browser_drupal_langcode_mappings() to a utility method on LanguageNegotiator service, ensuring the plugins can be still made stateless

Remaining tasks

  1. Decide whether keeping BC procedural wrappers.
  2. Write a patch
  3. Sort out language_[g|s]et_browser_drupal_langcode_mappings()
  4. Fix failing tests
  5. Reviews

User interface changes

None

API changes

TBD

CommentFileSizeAuthor
#25 language-prefixes-url-2166919-25.patch7.38 KBdimaro
#14 language-prefixes-url-2166919.5.patch21.05 KBlarowlan
#14 interdiff.txt842 byteslarowlan
#12 language-prefixes-url-2166919.4.patch20.23 KBlarowlan
#12 interdiff.txt1.12 KBlarowlan
#9 language-prefixes-url-2166919.3.patch19.97 KBlarowlan
#9 interdiff.txt10.77 KBlarowlan
#8 language-prefixes-url-2166919.2.patch9.4 KBlarowlan
#8 interdiff.txt1.12 KBlarowlan
#5 language-prefixes-url-2166919.1.patch9.36 KBlarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Issue summary: View changes
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Issue summary: View changes
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Postponed » Active

The parent issue has been committed.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Assigned: Unassigned » larowlan

taking a crack at this

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Assigned: larowlan » Unassigned
Status: Active » Needs review
FileSize
language-prefixes-url-2166919.1.patch9.36 KB
  1. Removed them
  2. Here tis
  3. Let's see
  4. Depends on 3

Status: Needs review » Needs work

The last submitted patch, 5: language-prefixes-url-2166919.1.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

Since plugins will require configuration, I am afraid this might conflict with #2174619: Make language negotiation plugins stateless. It might be good to ask sun's feedback.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
interdiff.txt1.12 KB
language-prefixes-url-2166919.2.patch9.4 KB

Overloaded the $language variable

Re 'keeping them stateless' this doesn't actually touch the plugins, just the form - update summary

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue summary: View changes
FileSize
interdiff.txt10.77 KB
language-prefixes-url-2166919.3.patch19.97 KB

Took care of the language_{g,s}et_browser_drupal_langcode_mappings functions too.

Status: Needs review » Needs work

The last submitted patch, 9: language-prefixes-url-2166919.3.patch, failed testing.

The last submitted patch, 8: language-prefixes-url-2166919.2.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.12 KB
language-prefixes-url-2166919.4.patch20.23 KB

ckeditor change broke installation
nfi why ckeditor plugins are loaded during install process, but regardless.

Status: Needs review » Needs work

The last submitted patch, 12: language-prefixes-url-2166919.4.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Needs review
FileSize
interdiff.txt842 bytes
language-prefixes-url-2166919.5.patch21.05 KB

needed a new ckeditor instance after enabling language in the test

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue summary: View changes
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

Why are we removing the functions and not adding @deprecated to existing functions?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

They have only been in core since #1862202: Objectify the language system see comment 294
Ie they were added in this cycle (last week) and are no longer needed.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

Ohk then it is all good but I'll let @plach or @sun RTBC the issue.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

14: language-prefixes-url-2166919.5.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 14: language-prefixes-url-2166919.5.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Issue tags: +beta target

It would really be better to have this sorted out before beta. I will try to review this ASAP.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Issue tags: +Needs reroll

This needs a reroll

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

#2404407: language_set_browser_drupal_langcode_mappings() is a useless wrapper, so remove it implemented part of this.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Related issues: +#2404407: language_set_browser_drupal_langcode_mappings() is a useless wrapper, so remove it
dimaro’s picture

dimaro CreditAttribution: dimaro commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
language-prefixes-url-2166919-25.patch7.38 KB

Rerolled #14

Hope it works.

Status: Needs review » Needs work

The last submitted patch, 25: language-prefixes-url-2166919-25.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Version: 8.0.x-dev » 8.2.x-dev
Issue tags: -beta target

This issue was marked as a beta target for the 8.0.x beta, but is not applicable as an 8.1.x beta target, so untagging.

I've moved the issue to 8.2.x since it could be possible to implement this with BC in a minor.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.