When using this module in an RTL site, the module list appears "compressed" because it leaves 240 pixels on the left, although the tabs are displayed on the right.
collapsed/expanded icons are also LTR only.

CommentFileSizeAuthor
#13 Screenshot 2024-04-01 at 11.09.33 AM.png212.04 KBsmustgrave
#4 module_page_is_not_rtl-2161755-4.patch1.49 KBYago Elias
#3 interdiff-2-3.patch426 byteshejazee
#3 module_filter_rtl_support-2161755-3.patch2.09 KBhejazee
#2 collapsed-rtl.png158 byteshejazee
#2 module_filter_rtl_support-2161755-2.patch2.06 KBhejazee

Issue fork module_filter-2161755

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daneshjoo’s picture

daneshjoo CreditAttribution: daneshjoo commented

I add this line but it dont work goodly.

hejazee’s picture

hejazee CreditAttribution: hejazee as a volunteer commented
Issue summary: View changes
Status: Active » Needs review
FileSize
module_filter_rtl_support-2161755-2.patch2.06 KB
collapsed-rtl.png158 bytes

This patch fixed this problem and a few other RTL related bugs.
Please review it

Note:
You should also download the attached image (collapsed-rtl.png)
and place it under the images/ folder

hejazee’s picture

hejazee CreditAttribution: hejazee as a volunteer commented
FileSize
module_filter_rtl_support-2161755-3.patch2.09 KB
interdiff-2-3.patch426 bytes

Module version numbers should be LTR (new option in 7.x-2.x-dev)

Yago Elias’s picture

Yago Elias CreditAttribution: Yago Elias as a volunteer and at CI&T commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +ciandt-contrib
FileSize
module_page_is_not_rtl-2161755-4.patch1.49 KB

Hello @hejazee your patch looks good. Just reorded to alphabetic order your rules.

andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Issue tags: -RTL, -ciandt-contrib +Module Filter Release 7.x-2.3
andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Assigned: Unassigned » andrey.troeglazov
jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented
Version: 7.x-2.x-dev » 4.x-dev
Status: Reviewed & tested by the community » Needs work

This will need to be fixed in 4.x first.

Just for info, csslint reports this problem:

css/module_filter.css
15	Negative text-indent doesn't work well with RTL. If you use text-indent for image replacement explicitly set direction for that item to ltr.

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !17

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Needs review

Not the best css person.

Other option we get rid of the clear button and just rely on type="search" x

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work

Should make sure to remove RTL

for example https://www.drupal.org/project/drupal/issues/3294001

smustgrave closed merge request !17

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Closed (cannot reproduce)
FileSize
Screenshot 2024-04-01 at 11.09.33 AM.png212.04 KB

With the latest changes that have gone in the last year I tested again and am not noticing any issue anymore.
See screenshot.

If anyone is still experiencing this though please reopen.