Part of #1839338: [meta] Remove drupal_set_*() drupal_add_*() in favour of #attached/response for out-of-band stuff.

CommentFileSizeAuthor
#1 2160577-drupal_add-batch-1.patch640 bytesvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
FileSize
2160577-drupal_add-batch-1.patch640 bytes

Initial patch...

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Title: Remove drupal_add_js() from batch.inc » Remove drupal_add_js() + drupal_add_library() from batch.inc
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Isn't it better to replace the theme function with a render array while we are on it?

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs review

Not sure that's scope of this issue...

Status: Needs review » Needs work

The last submitted patch, 1: 2160577-drupal_add-batch-1.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review

1: 2160577-drupal_add-batch-1.patch queued for re-testing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs review » Closed (duplicate)

Indeed, #3, as #4 says, that's out of scope.

However… #2068471: Normalize Controller/View-listener behavior with a Page object did precisely that, and also fixed this issue in the process. YAY :)