I have a site that is getting very large, and I need to see what nodes have overridden the default XML sitemap settings. I thought I could just create an admin View with a table, and columns that showed the inclusion and priority settings for each node. I was surprised to find that this wasn't possible.

I am willing to try to write this, but I wanted to make sure: Has anyone already started working on this, maybe in a sandbox or somewhere else? I wouldn't want to duplicate effort.

CommentFileSizeAuthor
#27 interdiff.txt3.16 KBRoloDMonkey
#27 xmlsitemap-views_fields-2159207-27.patch12.02 KBRoloDMonkey
#23 xmlsitemap-views_fields-2159207-23.patch12.03 KBRoloDMonkey
#19 xmlsitemap-views_fields-2159207-19.patch11.99 KBRoloDMonkey
#7 xmlsitemap-views_fields-2159207-6.patch0 bytesRoloDMonkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey commented
Issue summary: View changes
RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey commented

Okay, I wrote it myself:

https://drupal.org/node/2161731

Should I petition to make this into a separate module, or do you think it should be merged in with the XML sitemap module?

RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey commented
Status: Active » Needs review
RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey commented
Related issues: +#2282481: [D7] XML sitemap views fields, +#2282483: Applied for full project status

I have polished up my module and applied to have it promoted to a full project. I have added links to the relevant related issues.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

+1. Would like to see a patch to review, I think this would make a great feature.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Needs work

Looks like this needs work then.

RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey at FFW commented
FileSize
xmlsitemap-views_fields-2159207-6.patch0 bytes

Here is the patch. Let me know what you think.

RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey commented
Status: Needs work » Needs review
RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey as a volunteer commented

Okay, this is why I wanted to create a separate module. This issue is now 16 months old. My module was ready for release a year ago. But, when Dave asked that I add the feature here instead, I obliged him and re-wrote my code.

That was nine months ago.

I spent a lot of time on this. I did everything I was asked. Other people have said that they would like to see this feature. What does it take to get it approved?

StephanieFuda’s picture

StephanieFuda CreditAttribution: StephanieFuda as a volunteer commented

Hi Everybody,
I can help test this, I'll provide some feedback early this week.
Thanks!

capogeannis’s picture

capogeannis CreditAttribution: capogeannis as a volunteer commented

Came across this after realizing views pages are unfortunately not included in the sitemap.

Has that patch in #7 been working well enough for you? Would really like to fix this asap. Thanks.

RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey as a volunteer commented

@capogeannis If I am reading your comment correctly, then this is not what you are looking for. This allows you to make views that include information from the Sitemap XML module. It does not fix the problem of views not being added to the sitemap.

capogeannis’s picture

capogeannis CreditAttribution: capogeannis as a volunteer commented

Ah shoot, sorry. I should have come back and fixed my comment (or removed it). Found my solution via XML Sitemap Custom.

patbranch’s picture

patbranch CreditAttribution: patbranch commented

@capgeannis

What's XML Sitemap Custom?

ericwenger’s picture

ericwenger CreditAttribution: ericwenger commented

I'm also working with a larger site which would benefit from this functionality

Status: Needs review » Needs work

The last submitted patch, 7: xmlsitemap-views_fields-2159207-6.patch, failed testing. View results

bernig’s picture

bernig CreditAttribution: bernig as a volunteer commented

Hi,
The patch looks empty to me.

I tried your sandbox module and it works great. Thank you very much.

chegor’s picture

chegor CreditAttribution: chegor at OAO Solution Spark commented

Yes, I also can't see anything in the patch file.

RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey as a volunteer and commented
Status: Needs work » Needs review
FileSize
xmlsitemap-views_fields-2159207-19.patch11.99 KB

I don't know what happened to the original patch that uploaded years ago. I have tried to create a new version, and have attached it here.

Status: Needs review » Needs work

The last submitted patch, 19: xmlsitemap-views_fields-2159207-19.patch, failed testing. View results

RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey as a volunteer and commented
RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey as a volunteer and commented

Hmm, when I run my new test all by itself on simplytest.me, it passes with flying colors. When I run all of the XML Sitemap tests together, with my new one last then I get an error?

RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey as a volunteer and commented
Status: Needs work » Needs review
FileSize
xmlsitemap-views_fields-2159207-23.patch12.03 KB

I think this will work. I need to tell Drupal that the Views module is required for my tests.

RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey as a volunteer and commented

Woohoo! We finally have passing tests on a 5 year old issue!

Now, if only someone would review it...

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work

Some minor things:

  • The comments should be wrapped to 80 chars, not the 50-60 that some of them currently are.
  • The "LATER" comments should be listed as @todo items so they show up in a code search.
  • The xmlsitemap.info file needs a test_dependencies line for Views.
  • I suggest creating a directory for the tests, a new issue could be added to move the other test file into the directory too.
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

BTW it's also worth pointing out that the new test file isn't actually running yet because testbot takes its list of dependencies from what's in the latest git HEAD. New dependencies have to be committed first as a separate patch and then you can reference them in tests.

RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey as a volunteer and commented
Status: Needs work » Needs review
FileSize
xmlsitemap-views_fields-2159207-27.patch12.02 KB
interdiff.txt3.16 KB

I have made the recommended changes.

I understand that the tests might not be running yet. If it helps, I have confirmed that the tests pass.

wjackson’s picture

wjackson CreditAttribution: wjackson at Kanopi Studios commented
Status: Needs review » Reviewed & tested by the community

The patch provided by RoloDMonkey worked for me. Updating to RTBC. Thank you all for your work on this issue!

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at Drupal Ukraine Community, GOLEMS GABB for Drupal Ukraine Community, GOLEMS GABB commented

  • pifagor committed dea7af3 on 7.x-2.x authored by RoloDMonkey 
    Issue #2159207 by RoloDMonkey, capogeannis, DamienMcKenna, StephanieFuda...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at Drupal Ukraine Community, GOLEMS GABB for Drupal Ukraine Community, GOLEMS GABB commented
Status: Reviewed & tested by the community » Fixed
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Status: Fixed » Patch (to be ported)

Presumably this would need to be ported to 8.x-1.x as well?

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Version: 7.x-2.x-dev » 8.x-1.x-dev