Add a 'product has type' as commerce product discount condition [#2159165]

I had a situation where I need to give commerce discount depending on the products type. I found another issue discussing similar feature request here.

This is a screenshot of the functionality that it adds.

Commerce discount with product type as condition

The attached patch is against the dev version of the module.

Comment	File	Size	Author
#4	inline_conditions-add_product_type_condition-2155893-4.patch	4.24 KB	jkuma
#4
#1	inline_conditions-add_product_type_condition-2155893.patch	4.18 KB	pontus_nilsson
#1
	commerce_discount_product_type.png	15.03 KB	pontus_nilsson

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

pontus_nilsson

Stockholm

CreditAttribution: pontus_nilsson commented 18 December 2013 at 14:56

Issue summary:	View changes
Related issues:		+#2155893: Add configuration for Product Type

File	Size
inline_conditions-add_product_type_condition-2155893.patch	4.18 KB

Comment #2

pontus_nilsson

Stockholm

CreditAttribution: pontus_nilsson commented 18 December 2013 at 14:56

Issue summary:

View changes

Comment #3

pontus_nilsson

Stockholm

CreditAttribution: pontus_nilsson commented 18 December 2013 at 14:59

Title:

Add a 'product has type' for commerce product discount condition

» Add a 'product has type' as commerce product discount condition

Comment #4

jkuma CreditAttribution: jkuma commented 20 February 2014 at 17:32

Status:

Needs review

» Fixed

File	Size
inline_conditions-add_product_type_condition-2155893-4.patch	4.24 KB

Hello pontus_nilsson,

Thanks for the patch, it's well written, and it's working good to me. I've just added this line to allow granted users to easily update the product type criterion from the rule condition itself.

          'description' => t('Enter the product type to compare against the passed product line item.'),
          'options list' => 'commerce_product_type_options_list',

Pushed in 7.x-1.x branch. diff