WSOD trying to save the survey content type instance [#2157237]

Hi
Ok, I've got ls sync installed and working. I can create a survey instance, execute the survey, and see the results in my drupal site. Really cool!

After doing this, and answering the survey once, I tried to edit the content type into which the survey results are stored. When I try to save this content type's settings, I get a WSOD, and looking in error_log I see
Call to undefined function ls_survey_answ_options_validate() in /home4/xxx/public_html/includes/form.inc on line 1465

Help?

The survey still works. I just can't change the features of its content type. I wanted to modify the location settings of the content type so they would not show when you view the survey results node.

The settings in my content type are:
-- open into an iFrame
-- Automatically overwrite
-- automatically fit to the user window
-- expiration period: 1 day
-- this specific page:
-- response title options: all defaults
-- response display page options: all defaults
-- response sync options:
-- -- specific user has been set
-- -- fill the token table is checked. Other checkboxes unchecked.

Thanks

Comment	File	Size	Author
#6	fix_wsof_saving_answer_content_type-2157237-6(file).zip	9.34 KB	thedut
#6	fix_wsof_saving_answer_content_type-2157237-6.patch	2.33 KB	thedut
#3	WSOD_on_editing_answers_content_types-2157237-3(file).zip	9.14 KB	thedut
#3	WSOD_on_editing_answers_content_types-2157237-3.patch	579 bytes	thedut

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

hanksterr7 CreditAttribution: hanksterr7 commented 16 December 2013 at 03:17

Priority:

Major

» Normal

Comment #2

hanksterr7 CreditAttribution: hanksterr7 commented 16 December 2013 at 03:20

Ok, I figured out what's going on. I changed the priority from Major to Normal as a consequence.

I was trying to edit the content type from admin/structure/types. That is not valid for these content types created from the Survey instance.

Instead, if I open the survey node and click its options tab, that opens up the same form as I see if I were editing the content type from admin/structure/types. But this time, when editing from the survey's options tab, I can save my changes.

Not sure what can be done to disable interacting with the content type from admin/structure/types (or at least pop up a message). WSOD's are not nice.

Thanks

Comment #3

thedut CreditAttribution: thedut commented 19 December 2013 at 00:49

Assigned:	Unassigned	» thedut
Status:	Active	» Needs review

File	Size
WSOD_on_editing_answers_content_types-2157237-3.patch	579 bytes
WSOD_on_editing_answers_content_types-2157237-3(file).zip	9.14 KB

Hello hanksterr7,

Thank you for reporting this bug.
User should be able to edit the answer content type using either admin/structure/types page or the Survey option tab.
I'm not able to reproduce this issue but thanks to the informations you have provided, I guess this patch may fix it.
Could you confirm ?

Comment #4

hanksterr7 CreditAttribution: hanksterr7 commented 27 December 2013 at 23:21

Hi thedut,

Sorry for the delay in trying out your patch.

I replaced ls_survey.module with the file in the second attachment

I then tried to open an existing survey result content type via http://example.com/admin/structure/types/manage/test-test-type

I get a WSOD, and looking in error_log I see
7-Dec-2013 18:14:08 America/New_York] PHP Fatal error: Call to undefined function limesurvey_sync_disable_overlay() in /home4/example/public_html/sites/all/modules/limesurvey_sync/ls_survey/ls_survey.module on line 533

Prior to making this change, I could open http://example.com/admin/structure/types/manage/test-test-type
but when I try to save, I get a wsod and in error_log I see
7-Dec-2013 18:10:14 America/New_York] PHP Fatal error: Call to undefined function ls_survey_answ_options_validate() in /home4/example/public_html/includes/form.inc on line 1465

I can edit the survey result content type via the options tab with no difficulty at
http://example.com/node/#/options

Hope this helps
-- Hank

Comment #5

thedut CreditAttribution: thedut commented 8 January 2014 at 11:19

Status:

Needs review

» Needs work

Yes, thank you Hank for reporting.
I am gointo to prepare a new patch, trying to kill this issue. I will post it here.

Comment #6

thedut CreditAttribution: thedut commented 22 January 2014 at 09:45

Status:

Needs work

» Needs review

File	Size
fix_wsof_saving_answer_content_type-2157237-6.patch	2.33 KB
fix_wsof_saving_answer_content_type-2157237-6(file).zip	9.34 KB

2 files were hidden/shown/deleted

File	Size
WSOD_on_editing_answers_content_types-2157237-3.patch	579 bytes
WSOD_on_editing_answers_content_types-2157237-3(file).zip	9.14 KB

Hello Hank,

Could you test this new patch please (just unzip and replace the ls_survey/ls_survey.module file) and report if it solves this issue ?

Comment #7

hanksterr7 CreditAttribution: hanksterr7 commented 23 January 2014 at 23:01

Works! No more WSOD editing the survey result content type directly at admin/structure/types. I can also continue to edit the content type via the Options tab for the Survey content type instance.

Thanks!