Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #2073819: [META] Remove direct calls to drupal_add_css().
Problem/Motivation
Remove the drupal_add_css() from comments, docblock:
- /core/includes/ajax.inc
- /core/lib/Drupal/Core/Ajax/AjaxResponse.php
- /core/lib/Drupal/Core/Asset/CssCollectionGrouper.php
- /core/modules/system/system.api.php
- /core/modules/views_ui/lib/Drupal/views_ui/ViewFormControllerBase.php
Proposed resolution
Fix the listed above...
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#5 | drupal8core-docchange-2157091-5.patch | 5.47 KB | kelmadics |
#3 | Remove.remaining.drupal_add_css.references.from_.documents.patch | 4.23 KB | martin107 |
Comments
Comment #1
star-szrSeems like a good novice task.
Comment #2
vijaycs85Yep,more of documentation.
Comment #3
martin107 CreditAttribution: martin107 commentedHere is an initial first pass.
The language used feels slightly clumsy but this is inkeeping with the original comments.
I will make deeper edits if requested, but is this outside the scope of the issue?
Note that it is impossible to remove all reference to drupal_add_css/js as some of them related to @todo's to change the code
once the deprecated function calls are removed.
Comment #4
vijaycs85Thanks @martin107, let testboat review it.
Comment #5
kelmadics CreditAttribution: kelmadics commentedadd edits to ajax.inc and ajaxresponse.inc
Comment #6
martin107 CreditAttribution: martin107 commentedComment #7
catchCommitted/pushed to 8.x, thanks!