Apply changes in devel once #2143263: Remove "Field" prefix from FieldDefinitionInterface methods is in core.

CommentFileSizeAuthor
#1 remove_field_prefix-2153541-1.patch7.2 KBplopesc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented
Status: Active » Needs review
FileSize
remove_field_prefix-2153541-1.patch7.2 KB

Patch.

Status: Needs review » Needs work

The last submitted patch, 1: remove_field_prefix-2153541-1.patch, failed testing.

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented
Status: Needs work » Needs review

Marking as Needs Review because tests related to this patch are green.
Create issue that fixed current broken test (DevelMailTest) #2153679: Fix call to undefined constant MAIL_LINE_ENDINGS in DevelMailLog.php

Regards.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented

1: remove_field_prefix-2153541-1.patch queued for re-testing.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented

Nah, it doesn't want to run if the repo isn't green...

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Status: Needs review » Fixed

Pushed to unblock the testbot. After that the patch will turn red because it can't be applied a second time.

Thank you, plopesc!

Status: Fixed » Needs work

The last submitted patch, 1: remove_field_prefix-2153541-1.patch, failed testing.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented

As expected, but the repo is green again. :-)

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.