Clean up for tablesort-indicator.html.twig

1: 2152261-1-tablesort-cleanup.patch queued for re-testing.

This looks pretty great to me!

+++ b/core/modules/system/templates/tablesort-indicator.html.twig
@@ -13,6 +13,8 @@
+{% if style == 'asc' -%}
+  <img src="{{ url('core/misc/arrow-asc.png') }}" width="13" height="13" alt="{{ 'sort ascending'|t }}" title="{{ 'sort ascending'|t }}"  />
+{% else -%}
+  <img src="{{ url('core/misc/arrow-desc.png') }}" width="13" height="13" alt="{{ 'sort descending'|t }}" title="{{ 'sort descending'|t }}"  />
+{% endif %}

There are two spaces between the closing quote and the />, should just be one.

Thanks @joelpittet! Reviewing this again, a couple things doc-wise to fix up:

1. We should remove this line from tablesort-indicator.html.twig:
@see template_preprocess_tablesort_indicator()

2. We're no longer providing image or uri to the template so those variables can be removed from the template docblock.

And I want to mention that with rdf.module enabled we lose typeof="foaf:Image" but that seems fine to me in this context. I'm liking that seven could now just override this template instead of writing a big preprocess for its tweaks.

Before:

<img typeof="foaf:Image" src="http://d8.dev/core/misc/arrow-asc.png" width="13" height="13" alt="sort ascending" title="sort ascending" />

After:

<img src="/core/misc/arrow-asc.png" width="13" height="13" alt="sort ascending" title="sort ascending" />

Also I think this is followup for #1939090: Convert theme_tablesort_indicator() to Twig if I'm not mistaken.

@Cottser: I'd be fine with losing foaf:Image - let me know if go that route and I can create a follow up issue to reflect that in the rest of the RDF implementation.

EDIT: I misread the issue. we're no longer calling theme_image() and instead hard coding the img element in Twig. It's perfectly fine to lose the foaf:Image, please go ahead (no follow up of any kind required).

Thanks @scor! I like this change a lot, RTBC from me.

Nice clean-up. Committed to 8.x. Thanks.