Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
Is there plans to introduce D8 version of this module?
We would like to help you with development of this version or to implement it from scratch.
Thanks,
mikro_O
Comment | File | Size | Author |
---|---|---|---|
#26 | menu_token.png | 91.35 KB | diogogomes77 |
#20 | menu_token.zip | 11.26 KB | peter.draucbaher |
#8 | menu_token-drupal_8_port-2150611-8.patch | 5.3 KB | serhii.ua |
Comments
Comment #1
DevElCuy CreditAttribution: DevElCuy commentedThis is great news @mikro_O.
I'm still a believer on Drupal's do-ocracy so please provide me with more details on what you want to do exactly. If things make sense to me will grant you full access to the project so you can make D8 version of this module to happen. Will that work?
Comment #2
Iziaslav CreditAttribution: Iziaslav commentedPlanned to be refactored code for drupal8 and further improve it. If you can, please, add me as a (co-)maintainers.
Comment #3
DevElCuy CreditAttribution: DevElCuy commentedOk @mikro_O, you got write access to git repo. Please work on the 8.x-1.x-dev branch.
P.S: You can contact me at any time here http://drupal.org/user/125473/contact
Comment #4
DevElCuy CreditAttribution: DevElCuy commentedComment #5
Iziaslav CreditAttribution: Iziaslav commentedHere is the first patch which implements menu, configs, changes variables, and changes theme_function.
Comment #6
Iziaslav CreditAttribution: Iziaslav commentedComment #7
DevElCuy CreditAttribution: DevElCuy commentedThis is a great new years gift @mikro_O!
I'm so busy organizing http://picchu2014.dlatino.org but going to get back to you on February, when things are more smooth.
Everyone else please make reviews of patch at #5, guess we can release for Drupal 8 pretty soon if we work together!
Comment #8
serhii.ua CreditAttribution: serhii.ua commentedHi,
I spread my patch for porting the module to Drupal 8.
Currently this module can not be fully ported, as dependent on the following modules: token and ctools. Since they have not ported, I think that work should be postponed for now.
I will continue to work with the module when these modules (token, ctools) would ported to D8.
Comment #9
DevElCuy CreditAttribution: DevElCuy commentedThanks for that @id.alan!
Keep up the good work team, together we can make it to the top of D8 modules.
Comment #10
Philalawst CreditAttribution: Philalawst commentedhello,
Thanks for the start of porting of this project.
do you plan its pursuit ?
Phil
Comment #11
DevElCuy CreditAttribution: DevElCuy at Dilygent commentedToken module is still on alpha stage, once it gets to beta we can start working on a Drupal 8 port of Menu token.
Comment #12
DanielVezaI would also be open to spending some time getting this onto D8 when it's ready for dev.
Comment #13
AdamPS CreditAttribution: AdamPS commentedI spotted that token module has now reached beta.
Comment #14
DevElCuy CreditAttribution: DevElCuy at Dilygent commentedOK, OK, OK... We can't keep delaying it.
Since D8 is quite a different beast, we need to rebuild Menu Token from scratch. MVP specs:
1. Override/Overwrite menu links
2. Add extra data to menu items in a D8 friendly way
3. l10n support
4. CMI support
Anything else we need for the very first ALPHA MVP of Menu token?
Comment #15
seanlang1 CreditAttribution: seanlang1 commentedAny update on this?
Comment #16
DarkstarTom CreditAttribution: DarkstarTom commentedI would love a Drupal 8 version of this, any news?
Comment #17
csunny CreditAttribution: csunny commentedAny update? I need this desperately, or I am now repeat custom code/menu creation. Please add me as co-maintainer for the D8 version.
Comment #18
DevElCuy CreditAttribution: DevElCuy at Dilygent commentedWelcome onboard @csunny!
Comment #19
peter.draucbaher CreditAttribution: peter.draucbaher as a volunteer commentedHi,
I also need the module. I am rewriting it from scratch based on the d7 version.
"Csunny" what is your progress can we somehow work together.
Comment #20
peter.draucbaher CreditAttribution: peter.draucbaher as a volunteer commentedHello,
After some trial and error I create a basic idea and module.
My thinking or idea is like that:
1. ) There is global configuration where admin chose what kind of entities does it want on the special route page.
2.) When the menu item is edited there is Use tokens in title and in path. like in version for 7 and all the configuration is listed for the entities that are selected in the global configuration.
I found out that if I hook on menu_token_form_menu_link_content_menu_link_content_form_alter then it will only hook on menu items that have a path and are not from views...
Did not found an object way of doing it. Hook alter is the only way at least as I know it.
3.) Chose what admin want in a link form context, random and so on...
4.) When it is saved the reuteBuilder must be call to dispach route event.
// Rebuild the router. So I can listen to event and change to routes.
$reuteBuilder = \Drupal::service('router.builder');
$reuteBuilder->rebuild();
5.) There is a route event listener for RoutingEvents::ALTER
where route have to be reconstructed on the configuration. That is at least an idea.
I put all in menu_token.zip if somebody is interested. Can you add me as co-maintainer for the D8 version and give me acess so I can commit.
Comment #21
peter.draucbaher CreditAttribution: peter.draucbaher as a volunteer commentedIf somebody is interested to have a look it is here: https://github.com/dravasoft/menu_token/tree/master
Comment #22
boshtian CreditAttribution: boshtian at Agiledrop - Your Trusted Drupal Teammates commentedI tested the module peter.draucbaher prepared and the things are more or less functional with all the functionalities Drupal 7 version of the module had.
There are probably some bugs that will be seen along the way, but it's definitely a good starting point. develCuy, if you can create 8.x branch and make this a dev version, I think we can start moving things.
Comment #23
Anonymous (not verified) CreditAttribution: Anonymous as a volunteer commentedThank you so much peter.draucbaher !
I've sent you a pull request on github to fix some spelling and enhance code readability a bit : https://github.com/dravasoft/menu_token/pull/1
Could the maintainer of this module create the dev branch ? This version is not perfect as it is, but I believe it's achieving the base functionalities needed by some. Let's move forward on this :)
Comment #24
peter.draucbaher CreditAttribution: peter.draucbaher as a volunteer commentedThank you.
My first open source contribution in my life... so bare with me;)
I tried to fix replacing even further, but have huge trouble with context...
Did some minor refactoring that other selection exept context work for all types... At least it shoud...
Comment #25
DevElCuy CreditAttribution: DevElCuy at Dilygent commentedThanks @peter.draucbaher! I granted you commit permissions, can you post your code to the 8.x-1.x branch yourself? Make sure to use your email address registered at drupal.org on every commit.
@boshtian, @machour thanks for help with testing!
Comment #26
diogogomes77 CreditAttribution: diogogomes77 commentedHello, I'm trying this module and it's not working.
I've used the options in the screen-shot I'm sending attached. Is there something wrong?
Comment #27
diogogomes77 CreditAttribution: diogogomes77 commentedHello, I've configured the module with the settings attached in screen-shot but it did not work. Is there anything wrong with my settings?
Comment #28
peter.draucbaher CreditAttribution: peter.draucbaher as a volunteer commentedContext does not work... "I tried to fix replacing even further, but have huge trouble with context..."...
Will try to fix it in the following days... when there will be time. Probably sometimes in next or week ahead.
Thanks for testing... if somebody else knows it is here in code...
menu_token.module on line 363 case "context":
Comment #29
DevElCuy CreditAttribution: DevElCuy at Dilygent commentedDoing some housekeeping here ;)
This issue is a feature request for the Drupal 8 version of Menu Token module, now that @peter.draucbaher is sending commits into the 8.x-1.x branch, this is not a feature request anymore, so this is fixed!
Everyone, please listen. If you have anything to report related to Drupal 8 version of Menu Token module, please create a separate issue, so that we can address new bugs and feature requests independently.
Thanks!