Hi,

Is there plans to introduce D8 version of this module?

We would like to help you with development of this version or to implement it from scratch.

Thanks,

mikro_O

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DevElCuy’s picture

This is great news @mikro_O.

I'm still a believer on Drupal's do-ocracy so please provide me with more details on what you want to do exactly. If things make sense to me will grant you full access to the project so you can make D8 version of this module to happen. Will that work?

Iziaslav’s picture

Planned to be refactored code for drupal8 and further improve it. If you can, please, add me as a (co-)maintainers.

DevElCuy’s picture

Ok @mikro_O, you got write access to git repo. Please work on the 8.x-1.x-dev branch.

P.S: You can contact me at any time here http://drupal.org/user/125473/contact

DevElCuy’s picture

Status: Active » Needs work
Iziaslav’s picture

Here is the first patch which implements menu, configs, changes variables, and changes theme_function.

Iziaslav’s picture

Status: Needs work » Needs review
DevElCuy’s picture

This is a great new years gift @mikro_O!

I'm so busy organizing http://picchu2014.dlatino.org but going to get back to you on February, when things are more smooth.

Everyone else please make reviews of patch at #5, guess we can release for Drupal 8 pretty soon if we work together!

serhii.ua’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Needs review » Postponed
FileSize
5.3 KB

Hi,

I spread my patch for porting the module to Drupal 8.

Currently this module can not be fully ported, as dependent on the following modules: token and ctools. Since they have not ported, I think that work should be postponed for now.

I will continue to work with the module when these modules (token, ctools) would ported to D8.

DevElCuy’s picture

Thanks for that @id.alan!

Keep up the good work team, together we can make it to the top of D8 modules.

Philalawst’s picture

hello,

Thanks for the start of porting of this project.
do you plan its pursuit ?

Phil

DevElCuy’s picture

Token module is still on alpha stage, once it gets to beta we can start working on a Drupal 8 port of Menu token.

DanielVeza’s picture

I would also be open to spending some time getting this onto D8 when it's ready for dev.

AdamPS’s picture

I spotted that token module has now reached beta.

DevElCuy’s picture

Status: Postponed » Active

OK, OK, OK... We can't keep delaying it.

Since D8 is quite a different beast, we need to rebuild Menu Token from scratch. MVP specs:

1. Override/Overwrite menu links
2. Add extra data to menu items in a D8 friendly way
3. l10n support
4. CMI support

Anything else we need for the very first ALPHA MVP of Menu token?

seanlang1’s picture

Any update on this?

DarkstarTom’s picture

I would love a Drupal 8 version of this, any news?

csunny’s picture

Any update? I need this desperately, or I am now repeat custom code/menu creation. Please add me as co-maintainer for the D8 version.

DevElCuy’s picture

Welcome onboard @csunny!

peter.draucbaher’s picture

Hi,

I also need the module. I am rewriting it from scratch based on the d7 version.
"Csunny" what is your progress can we somehow work together.

peter.draucbaher’s picture

FileSize
11.26 KB

Hello,

After some trial and error I create a basic idea and module.

My thinking or idea is like that:

1. ) There is global configuration where admin chose what kind of entities does it want on the special route page.
2.) When the menu item is edited there is Use tokens in title and in path. like in version for 7 and all the configuration is listed for the entities that are selected in the global configuration.

I found out that if I hook on menu_token_form_menu_link_content_menu_link_content_form_alter then it will only hook on menu items that have a path and are not from views...

Did not found an object way of doing it. Hook alter is the only way at least as I know it.

3.) Chose what admin want in a link form context, random and so on...

4.) When it is saved the reuteBuilder must be call to dispach route event.
// Rebuild the router. So I can listen to event and change to routes.
$reuteBuilder = \Drupal::service('router.builder');
$reuteBuilder->rebuild();

5.) There is a route event listener for RoutingEvents::ALTER
where route have to be reconstructed on the configuration. That is at least an idea.

I put all in menu_token.zip if somebody is interested. Can you add me as co-maintainer for the D8 version and give me acess so I can commit.

peter.draucbaher’s picture

If somebody is interested to have a look it is here: https://github.com/dravasoft/menu_token/tree/master

boshtian’s picture

I tested the module peter.draucbaher prepared and the things are more or less functional with all the functionalities Drupal 7 version of the module had.

There are probably some bugs that will be seen along the way, but it's definitely a good starting point. develCuy, if you can create 8.x branch and make this a dev version, I think we can start moving things.

Anonymous’s picture

Thank you so much peter.draucbaher !
I've sent you a pull request on github to fix some spelling and enhance code readability a bit : https://github.com/dravasoft/menu_token/pull/1

Could the maintainer of this module create the dev branch ? This version is not perfect as it is, but I believe it's achieving the base functionalities needed by some. Let's move forward on this :)

peter.draucbaher’s picture

Thank you.

My first open source contribution in my life... so bare with me;)
I tried to fix replacing even further, but have huge trouble with context...
Did some minor refactoring that other selection exept context work for all types... At least it shoud...

DevElCuy’s picture

Thanks @peter.draucbaher! I granted you commit permissions, can you post your code to the 8.x-1.x branch yourself? Make sure to use your email address registered at drupal.org on every commit.

@boshtian, @machour thanks for help with testing!

diogogomes77’s picture

FileSize
91.35 KB

Hello, I'm trying this module and it's not working.
I've used the options in the screen-shot I'm sending attached. Is there something wrong?

diogogomes77’s picture

Category: Feature request » Bug report

Hello, I've configured the module with the settings attached in screen-shot but it did not work. Is there anything wrong with my settings?
ok

peter.draucbaher’s picture

Context does not work... "I tried to fix replacing even further, but have huge trouble with context..."...
Will try to fix it in the following days... when there will be time. Probably sometimes in next or week ahead.
Thanks for testing... if somebody else knows it is here in code...
menu_token.module on line 363 case "context":

DevElCuy’s picture

Assigned: Unassigned » peter.draucbaher
Category: Bug report » Feature request
Priority: Normal » Major
Status: Active » Fixed

Doing some housekeeping here ;)

This issue is a feature request for the Drupal 8 version of Menu Token module, now that @peter.draucbaher is sending commits into the 8.x-1.x branch, this is not a feature request anymore, so this is fixed!

Everyone, please listen. If you have anything to report related to Drupal 8 version of Menu Token module, please create a separate issue, so that we can address new bugs and feature requests independently.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.