By mistake, I added agrcache instead of advagg.

After installing advagg, the site simply went blank.
a) on line 882 of advagg.module, I had "only variables can be passed by reference". Fixed.
b) Then blank page (empty body)

Reasons for that was that agrcache was still installed.
Removing it solved the issue.

Can you add a warning about that?

CommentFileSizeAuthor
#1 advagg-2150465-1-move-module-checks.patch19.38 KBmikeytown2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Active » Fixed
FileSize
advagg-2150465-1-move-module-checks.patch19.38 KB

On line 882 of advagg.module, I had "only variables can be passed by reference".

  if (isset($variables['page']['page_top'])) {
    $variables['page_top'] = drupal_render($variables['page']['page_top']); // LINE 882.
  }
  elseif (!isset($variables['page_top'])) {
    $variables['page_top'] = '';
  }

What did you do in order to fix this? The isset should make sure the variable exists before calling drupal_render but if I missed something that would be good to fix.

I'll move the check for argcache inside of advagg_requirements from runtime to always. Following patch does that (& also flattens the if statement) and has been committed.

JulienThomas’s picture

JulienThomas CreditAttribution: JulienThomas commented

By I "fixed" this, I meant the following small update to do post analyzes :D:

    $variables['page_top'] = drupal_render($variables['page']['page_top']); // LINE

becomes

    $p_top  = variables['page']['page_top']
    if(!emtpy( $p_top )) $variables['page_top'] = drupal_render($p_top); // LINE

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.