See #1988612-208: Apply formatters and widgets to rendered entity base fields, starting with node.title. This is _nod's patch, so please credit him instead of me on commit.

CommentFileSizeAuthor
core-js-edit-funkyselector-1988612-208.patch777 byteseffulgentsia
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented

That's some fine code right there, I wish I could RTBC :p

Thanks for opening it.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Title: Improve edit module JS to use .find(...) instead of .is(':has(...)') » Improve Edit module JS to use .find(...) instead of .is(':has(...)')
Status: Needs review » Reviewed & tested by the community

Thanks! Code looks fine. Tested manually, all works fine. RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Issue tags: +Spark

Now also backported to the Drupal 7 contrib module, along with the changes made to Edit's JS in #1988612: Apply formatters and widgets to rendered entity base fields, starting with node.title: http://drupalcode.org/project/edit.git/commit/94bbc02. The end result is slightly cleaner markup in Drupal 7 :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.