Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The aggregator item description is currently a string field, but it's a perfect candidate for a text field.
Comments
Comment #1
amateescu CreditAttribution: amateescu commentedForgot to say that I'd prefer this to wait for #2112239: Convert base field and property definitions.
Comment #2
BerdirHm, we don't really have a format for it, as the data is always imported externally?
Comment #3
amateescu CreditAttribution: amateescu commentedHow about setting a default format?
Comment #4
yched CreditAttribution: yched commentedHow do we display it currently ?
Comment #5
BerdirWhich is
So yes, we could probably define a default format that does more or less the same, no idea what the preg_split() there does, though?
Comment #6
BerdirAh, that's just the splitting of the configuration into an array. So yes, then it would probably be quite nice to convert this into a text field with default format, we'd need to prevent that format from being deleted, though, or convert the setting into a filter selection?
Comment #7
ParisLiakos CreditAttribution: ParisLiakos commentedthats a nice idea:)
why dont we use the existing
restricted_html
text filter though?the "allowed html tags" setting in aggregator always felt weird.
but whats more important i think is: where we expose the Field UI for items, so this can be made configurable
Comment #8
ParisLiakos CreditAttribution: ParisLiakos commentedalso. we can get rid of
aggregator_teaser_length
since, this will be configurable from the field formatter as wellclosed #1830068: Change teaser_length to default_summary_length in aggregator? as duplicate
Comment #9
jibranComment #10
andypostAfter #2181549: Provide a StringLong field item with schema type 'text' without a 'format' column there would be a
string_long
field with proper text-blob storage.Formatter for that field seems will use text module.
The question here how to implement special (locked) text format while aggregator module installed so remove own filtering finctions
Comment #11
BerdirTried to write a quick patch for this, but noticed that aggregator_filter_xss() is also used for the author (only possible to display that in views), and the views integration will need to be updated. Seems a bit strange to also use a text field for that..
Comment #12
dcam CreditAttribution: dcam as a volunteer commentedUnless I've missed something when searching Aggregator's code, the teaser length setting can already be removed. I'm pretty sure it doesn't do anything in D8. See #2283877: Remove or use Aggregator's teaser_length setting.
Comment #13
Berdiraggregator_filter_xss() is gone but I don't think this can be done in 8.0.x. *Maybe* 8.1.x if we write an update function and don't consider the field type/storage an API, but maybe we have to.
Comment #22
AdamPS CreditAttribution: AdamPS at AlbanyWeb commentedThis issue seems to be covering two things
1) Use a formatter instead of extra field info. This is part of #2353867: [META] Expose Title and other base fields in Manage Display. The first step is included in #2993642: Mechanism to disable preprocessing of base fields in taxonomy and aggregator entity types so they can be configured via the field UI - that removes the special case processing so that a module could enable a formatter.
2) Converting the field from string to text would be challenging for BC. However do we really need that? It could work well if it remains as string with the aggregator_xss formatter. Then it doesn't need any complicated code to ensure a particular text format always exists.
Comment #27
quietone CreditAttribution: quietone at PreviousNext commentedThe
aggregator
module has been removed from Core in10.0.x-dev
and now lives on as a contrib module. Issues in the Core queue about theaggregator
module, like this one, have been moved to the contrib module queue.Comment #28
larowlan+1 for splitting this into two issues per the comment from @AdamPS