Message Type Category Views Integration [#2149527]

I added a new message type category (#2059533: How to create a Message category?) to filter messages by category in views. This Bug occured:

If I add a filter by message type category and use IN with the just inserted message type category and there is no message type of that category created, the filter will not apply and all messages will be displayed. I think this is due to the fact that instead of filtering by message type category the filter is converted to a IN() of message types that are inside of that message type category.

Comment	File	Size	Author
#6	message-category-views-integration-2149527-6.patch	1.1 KB	Rob230
#6
#4	message-category-views-integration-2149527-4.patch	1.07 KB	Rob230
#4
#1	message-type-category-views.export.php_.txt	2.08 KB	Andre-B

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Andre-B

German

Offenburg, Germany

CreditAttribution: Andre-B commented 4 December 2013 at 09:06

File	Size
message-type-category-views.export.php_.txt	2.08 KB

I added the export of that view

Comment #2

Andre-B

German

Offenburg, Germany

CreditAttribution: Andre-B commented 4 December 2013 at 09:12

Issue summary:

View changes

Comment #3

Rob230 CreditAttribution: Rob230 commented 28 July 2014 at 09:36

I can confirm that this is the case.

The issue is that the SQL query takes the form:

SELECT message.mid AS mid
FROM 
{message} message
WHERE ( message.type IN  ('test') )

If you have not created any message types for that particular category then the query won't have the WHERE clause, and thus will show all messages, such as those from other categories, which is incorrect behaviour.

It's not a major issue because really there shouldn't be cases on a production site where you have a message type category but no message types. It's the sort of thing that only occurs during development while you are setting things up.

Comment #4

Rob230 CreditAttribution: Rob230 commented 28 July 2014 at 10:03

File	Size
message-category-views-integration-2149527-4.patch	1.07 KB

Here is a patch.

Comment #5

Rob230 CreditAttribution: Rob230 commented 28 July 2014 at 10:49

That might need some more thinking through. I've only covered the case where the user chose 'in' for the operator. For the case where the user has chosen 'not in', I think the correct behaviour should be to change the operator to 'in'.