The beans all module depends on the Block module but the Block module is not listed as a dependency in the beans all info file. (Patch on it's way.)

CommentFileSizeAuthor
#1 adds_block_dependency-2146879.patch331 bytesDave Bagler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Bagler’s picture

Status: Needs work » Needs review
FileSize
331 bytes

Here's the patch.

indytechcook’s picture

Where is the dependency? module_implements('block_info') just implements the hook, it doesn't require the block module. The point of bean all is to implement other modules core blocks as bean types. It is possible that I missed something though.

raychaser’s picture

I'm not sure this should be in the been _all module. The core Bean module certainly has stuff to do with the 'block' table in its install file.

For me, the issue presented itself when I tried a drush makefile with a custom install profile that included bean.

Bean tried to install itself before the block module and I got an error about 'block_custom' table not being present.

From the same criteria "menu" is also required.

Dave Bagler’s picture

@raychaser, that's an interesting point. We were installing from an install profile as well but we weren't running into issues on the core Bean module, but on the Bean All module. I don't have time today, but I'll try installing Bean and Bean all on a site that has never had the blocks module installed soon and post back.

@indytechcook, as @raychaser mentioned it's at install time that the bean_all module is looking for the block_custom table and failing if it isn't there.

jonhattan’s picture

Dave Bagler’s picture

Same problem exists with bean all missing a dependency on the menu module #2176095: Bean All depends on Menu at install time

Dave Bagler’s picture

Dave Bagler’s picture

minorOffense’s picture

Assigned: Dave Bagler » Unassigned
indytechcook’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.