I just found myself in a weird situation: all my components were listed, but whenever i clicked on the component title or edit link i got a not found error:

The reason is, because somehow i ended up at
admin/config/workflow/rules/components/manage

instead of
admin/config/workflow/rules/components

What happens is, that if you go to a sub path of the components page, it will still list all the components for you, but their links are just wrong / they get appended to whatever your current URL is.

so you'd end up on pages like
admin/config/workflow/rules/components/manage/manage/rules_commerce_billy_set_to_invoiced

I couldn't reproduce this bug for the page of reaction rules (admin/config/workflow/rules).

edit: users are likely to run into this problem, because of the /manage link is listed as a duplicate breadcrumb of the components listing page when editing a component.

CommentFileSizeAuthor
#2 2146549-manage-path-2.patch799 bytescafuego
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
CreditAttribution: dasjo commented
Issue summary: View changes
cafuego’s picture

cafuego CreditAttribution: cafuego commented
Status: Active » Needs review
FileSize
2146549-manage-path-2.patch799 bytes

It looks like the RulesPluginUI::path() method always appends "/manage" to the base path it uses to generate sub-links on the overview page, and for components at least that base path is set to the current path.

That /manage at the end of the current path possibly only happens if your (admin) theme shows breadcrumbs and generates a crumb for each component of the path. Shiny certainly does that.

Attached patch tests if the base path already ends in "/manage" and doesn't append it this is the case. Not sure if this is the proper way to fix it, but as a workaround it's saving me a lot of time.

kaizerking’s picture

kaizerking CreditAttribution: kaizerking commented

This should be committed my site log is filled with page not found notices because of this issue

cafuego’s picture

cafuego CreditAttribution: cafuego commented

@kaizerking Can you flip the issue to RTBC status?

kaizerking’s picture

kaizerking CreditAttribution: kaizerking commented
Status: Needs review » Reviewed & tested by the community

cafuego queued 2: 2146549-manage-path-2.patch for re-testing.

  • fago committed 026953f on 7.x-2.x authored by cafuego 
    Issue #2146549 by cafuego, kaizerking, dasjo: Rules components listing...
fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago at drunomics commented
Status: Reviewed & tested by the community » Fixed

Thx, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.