Not functioning

hello Mark

I have exactly the same problems. did you find an issue ?

thanks

good idea. in my case I use "contact form on node", wich also prepopulates the subject field

contact_form_on_node

Hi there,

Did you succeeded to understand how the module works ?

no, the other was simpler, sorry

I recently ran into the same issue:

• The module does nothing just redirects to the front page... (action is /)
• There is an odd Save button at the bottom of the form... (whole thing is wrapped in another form tag)

#2146119: 'Save' button appears on contact form seems to be a duplicate of this.

I did some investigation and found that the culprit is the view_form() function which should not be overridden (at least I did not see this anywhere in the docs), instead the module should override the render() function.

The attached patch removes the view_form() function and implements render() instead.

class views_contact_form_handler extends views_handler_field_user_mail {

  function options_form(&$form, &$form_state) {
    parent::options_form($form, $form_state);
    $form['link_to_user']['#options']['views_contact_form'] = t('Contact form');
  }

  function render($values) {
    if ($this->options['link_to_user'] == 'views_contact_form') {
      // The view is empty, abort.
      if (empty($this->view->result)) {
        return;
      }

      $emails = array();
      foreach ($this->view->result as $row_index => $row) {
        $emails[] = $this->get_value($row);
      }

      if (empty($emails)) {
        return;
      }

      $data['emails'] = $emails;
      $form = drupal_get_form('views_contact_form_contact_form', $data);

      return drupal_render($form);
    }

    // Fallback to the default behavior.
    $value = $this->get_value($values);
    return $this->render_link($this->sanitize_value($value), $values);
  }

}

Amazing ! Nice find, I wasn't able to isolate the problem.

I will try the patch tonight and if everything goes well, commit it and release a new version too.

For the record, I used views_form() because someone on IRC (dawehner or berdir, I don't remember) told me to use it.

Anyway, thanks a lot !

#2144153-11: Not functioning patch not working, display empty views

I changed render function of @sgabe patch

views_contact_form_handler.inc

<?php

class views_contact_form_handler extends views_handler_field_user_mail {

  function options_form(&$form, &$form_state) {
    parent::options_form($form, $form_state);
    $form['link_to_user']['#options']['views_contact_form'] = t('Contact form');
  }

  function render($values) {
    if ($this->options['link_to_user'] == 'views_contact_form') {
      // The view is empty, abort.
      if (empty($this->view->result)) {
        return;
      }
      $emails = array();
      foreach ($this->view->result as $row_index => $row) {
        $emails[] = $this->get_value($row);
      }
      if (empty($emails)) {
        return;
      }
	  $value = $this->get_value($values);
      return $this->sanitize_value($value);
    }
    // Fallback to the default behavior.
    $value = $this->get_value($values);
    return $this->render_link($this->sanitize_value($value), $values);
  }
 
}

?>

And how are you displaying the contact form without these lines?

  $form = drupal_get_form('views_contact_form_contact_form', $data);
  return drupal_render($form);

@sgabe your patch is working fine. I selected both the options in views (Format views contact form and Link this field as contact form in field configuration). Sorry for this mistake.

Could you please upgrade to dev version, I just committed a fix for this and a bunch of other things.

Commit: http://cgit.drupalcode.org/views_contact_form/commit/?id=62d37ae