The attached patch fixes most of the issues reported by the Coder module (except a couple of FAPI issues, which are false positives as far as I can tell).

CommentFileSizeAuthor
#2 interdiff-2143711-0-2.txt1.67 KBSutharsan
#2 radioactivity-adhere-to-coding-standards-2143711-2.patch15.53 KBSutharsan
radioactivity-adhere-to-coding-standards.patch14.79 KBwulff
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wulff’s picture

wulff CreditAttribution: wulff commented

O.k., that was a little too heavy-handed ;-) Disregard the drupal_ucfirst() bit in emit.php.

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan commented
FileSize
radioactivity-adhere-to-coding-standards-2143711-2.patch15.53 KB
interdiff-2143711-0-2.txt1.67 KB
Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan commented

The module uses a mix of single and double quotes. Coning standards say: "Where possible, keep consistency within each module, and respect the personal style of other developers." I'd like to have feedback of the maintainer before bringing consistency into it (and using single over double quotes where possible.)