[user:name-raw] token checks are incorrect [#2142507]

Bug was introduced in #1827980: Post module enable/disable requirements (README): Account settings - E-mails require manual update

Account settings form validation fails if mail body template begins with [user:name-raw] token.
Relates to following mail templates:

Welcome (new user created by administrator) - email_admin_created -
Welcome (no approval required) - email_no_approval_required
Account activation - email_activated

There are also incorrect checks in hook_requirements().

Comment	File	Size	Author
#4	interdiff.txt	2.14 KB	AndreyMaximov
#4	realname-account_settings_form_fails_validation-2142507-4.patch	2.7 KB	AndreyMaximov
#4
#1	realname-account_settings_form_fails_validation-2142507-1.patch	645 bytes	AndreyMaximov
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

AndreyMaximov CreditAttribution: AndreyMaximov commented 23 November 2013 at 09:13

Issue summary:

View changes

File	Size
realname-account_settings_form_fails_validation-2142507-1.patch	645 bytes

Comment #2

AndreyMaximov CreditAttribution: AndreyMaximov commented 23 November 2013 at 09:14

Status:

Active

» Needs review

Comment #3

maximpodorov CreditAttribution: maximpodorov commented 23 November 2013 at 09:39

Status:

Needs review

» Reviewed & tested by the community

Obvious fix. Please commit.

Comment #4

AndreyMaximov CreditAttribution: AndreyMaximov commented 23 November 2013 at 13:08

Title:	Account settings form does not pass validation	» [user:name-raw] token checks are incorrect
Issue summary:	View changes

File	Size
realname-account_settings_form_fails_validation-2142507-4.patch	2.7 KB

interdiff.txt	2.14 KB

There are also incorrect checks in hook_requirements() resulting in red rows in status report.

Comment #5

AndreyMaximov CreditAttribution: AndreyMaximov commented 23 November 2013 at 13:11

Status:

Reviewed & tested by the community

» Needs review

Comment #6

dpovshed CreditAttribution: dpovshed commented 24 November 2013 at 20:49

Fix in #4 looks fine with me.

Comment #7

andypost

he/him

Russian

CreditAttribution: andypost commented 29 November 2013 at 08:50

Status:

Needs review

» Reviewed & tested by the community

good to go!

Comment #8

aclubb CreditAttribution: aclubb commented 7 December 2013 at 17:19

While this fix looks fine for what it does, there are sites which may be using both RealName and e.g. Email Registration modules, which will not want to include [user:name-raw] anywhere in the registration email, but instead use e.g. [user:mail]. The current approach prevents changes to registration emails for such sites, unless the unwanted [user:name-raw] is added.

While understand don't want users installing the RealName module to end-up with misleading registration emails, at least those are fixable, while the resolution breaks existing functionality. Would it be possible to look at modifying to provide REQUIREMENT_WARNINGs instead, so that sites installing are informed that they need to modify their email templates, whilst not breaking things for sites that don't want to have [user:name-raw] in the templates.