The WYSIWYG module did not detect CKEditor 4.3 or 4.1.3 versions

How to get CKEditor 4.x working with the Drupal 7 WYSIWYG module:
http://www.webopius.com/content/717/how-to-get-ckeditor-4-x-working-with...

Followed the fix in #1, I'm still stuck. Is there a trick to get WYSIWYG to refresh and check again?

You do not need any fix, just use dev version that recognize CKEditor 4.x directly and works fine.

"just use dev version" is not a very good advice for production sites to be honest.

CKEditor 4.x has been out for quite some time and it would be good it this module could be at least updated to recognize the currently recommended releases.

@tsvenson I believe you are right, but I prefer dev to patch version and also from experience, I know that there are other reasons why developers are waiting for next release. That dev comes from some patch and is validated by developers as working solution that (presumably) is working while waiting for some other things for new release (do not have to be CKE 4 related at all).

On the other hand, this works, it is not too complex to check if there are some undesired implications and one can always stick with version that works for them.

I've been using it for some time and it seems fine to me.

Sure, not every dev release can follow the same advice.

@MacMladen:

I think you might have misunderstood my comment a little. This isn't about if a working version is available in the dev release or as a patch. It's about that this module is dependent on third party libraries. Plus the fact that this module is useless without any of those third party libraries.

Thus, to be able to keep up to speed with those third party libraries there is a need for different release strategies. One for bug/security fixes, one for new functionality and one to keep up to speed with new releases of these third party libraries.

It is also a known problem that newer versions of some of the third party libraries, especially CKEditor, is not recognized by this module.

Also, those new third party library release can very well contain security fixes too.

The latest full release of the Drupal 7 version of this module was over 13 months ago. Thus, it is quite easy to draw the conclusion there is now strategy for keeping up to speed with third party libraries.

A dev version contains work in progress, new features that aren't fully tested and so on. Thus, again, just saying to user to use it on live production sites is not the way to do it.

Thank you, #1 worked for me. I did have a resulting error, which was quickly fixed by https://drupal.org/node/1883456 (#14).

#1 working, Can't understand why this was not resolved or patched.

and.. #1 patch will cause "Notice: Undefined offset: 2 in wysiwyg_ckeditor_version() (Line 85 from ckeditor.inc)." error.

#7 will resolve your second error. cheers!!

Time this was patched. Been going on way too long.

Thanks Perignon.

The patch in #9 works well.

Seems like the patch needs some update. did not work for me with 7.x-2.2

see updated patch.

@dasrecht This issue isn't against 7.x-2.2. This is against 7.x-2.x-dev. The code was changed between 2.2 and 2.x-dev, so hence why my patch would not work for 2.2 :-D.

See here: http://drupalcode.org/project/wysiwyg.git/history/ee64524b3edb2aa21098a2...

Version 2.2 of the CKeditor include was changed over a year ago. The Dev branch has several changes.

Eww, I am sorry my misstake :-|
Just ran into the issue today and tought to roll a patch.

I was running 2.2 like you. I switched to dev to fix a lot of the little nit-noid issues with WYSIWYG

I updated to 4.3.1 from 4.1.2 and the latest WYSIWYG 7.x-2.x-dev picked it up without any patch applied. The only issue I'm having is that the buttons in the toolbar are misaligned/messed up. They do work though, so this is merely a display issue. Anybody else seeing this (perhaps know of an issue filed for it - I searched but could not find any)?:

What would be a JS problem. Have you attempted to do things like: clear cache of browser completely, try another browser.... typical stuff like that.

I do admin work from firefox and test both there as an admin + on chrome as an authenticated user. The issue appears in both browsers even after clearing all caches from firefox as admin. Just to be sure I created a new vanilla profile in firefox and tested there and indeed the issue is not present.

My problem though is that I need this fixed in my current working profile as well where clearing all browser cache is not an option. Asking all of the site's authors to do the same is not an option either. Shouldn't a full (Drupal) cache clear solve this in theory? What other options do I have?

PS: I realize now that this is OT here, honestly sorry for that - I should know better, but too late now. If this takes more than a couple of more comments I promise to take it elsewhere.

...ok one last comment and that's it: What finally did the trick was adding a button (I randomly chose to use the "About" button) to the WYSIWYG profile, saving, then refreshing the edit page and then finally removing the added button and saving once again. That seems to have forced the browser-side cache to be refreshed. It initially worked only for firefox. Chrome required to also remove and add back an existing button in order for this magic to work.

Anyways, perhaps all this needs to be documented someplace or better if one knows of a way to actually achieve the same thing with code (some kind of custom, CKEditor-targeted cache clearing), then it should be implemented in order to spare users from the trouble I went through.

I'm now shutting up and once again sorry for the noise.

...in #16 I said:

I updated to 4.3.1 from 4.1.2 and the latest WYSIWYG 7.x-2.x-dev picked it up without any patch applied.

This might have got lost with all the comments about the messed up buttons, so I wanted to be clear that I have tested this in another couple of websites and 4.3.1 is detected by the latest dev of WYSIWYG without having to apply any patches. So, is this issue here still valid?

No, this issue is not valid. Initial CKEditor 4 support was committed long ago, and a few tweaks have been applied since.
I'm currently trying to clean up, and catch up with, the issue queue so I can focus on just the issues which need to - or are small enough - to be included before there is a new release.

Re-rolling patch from #12 for it to be make-file friendly.

@emanaton, please don't reroll this anymore. That patch is far from enough to make CKEditor 4 actually work.
It's all in Wysiwyg 7.x-2.x-dev now.