Update code to make work with current core

CommentFileSizeAuthor
#6 2137891-6.patch8.02 KBandypost
#5 2137891-5.patch5.98 KBandypost
#3 interdiff.txt545 bytesGábor Hojtsy
layout-follow-core.patch8.72 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

The proposed changes look good. Does this actually make the module work?

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

Yes it works, I need the module for #1840500: Add simple blank page creation capability which I make work too in my sandbox

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Fixed
FileSize
interdiff.txt545 bytes

Thanks. I did not have time/opportunity to test this, but all changes look good/logical visually. I only spotted a whitespace issue. So committed this with this whitespace fix :) Thanks. Keep the fixes coming!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Closed (fixed) » Needs review
FileSize
2137891-5.patch5.98 KB

Another chasing HEAD patch

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
FileSize
2137891-6.patch8.02 KB

Now uninstall works too

zmove’s picture

zmove CreditAttribution: zmove commented

Is it possible to have a 8.x-2.x package to download ? I encounter some problems patching the existing branch (tested the 1.0 alpha et the dev one, but got problems with both).

Thanks

Alex