Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In date_api_ical_build_rrule($form_values) inside date_api_ical.inc, we allow the system to potentially generate:
- a COUNT inside the rrule even when a count has not been explicitly set
- a COUNT and an UNTIL
If the user has not provided either a COUNT or an UNTIL date, then neither should be set. A COUNT is not allowed to be left empty, it must have a value or must not be part of the sting. If COUNT is left off and there is no UNTIL, then the RRULE is considered to be forever. If the user has supplied both, it is invalid, and then only one should win out.
This is all per RFC-2445 (4.3.10 Recurrence Rule).
I have marked this as major since it is in clear violation of the specification and is actually breaking integration with other systems.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | rrule_building_creates-2137757-8.patch | 1.56 KB | steve.colson |
| #1 | date-rrule-building-creates-invalid-syntax-2137757-1.patch | 1.26 KB | steve.colson |
Comments
Comment #1
steve.colson CreditAttribution: steve.colson commentedThe attached patch addresses the combination of these issues.
Comment #3
steve.colson CreditAttribution: steve.colson commented1: date-rrule-building-creates-invalid-syntax-2137757-1.patch queued for re-testing.
Comment #5
steve.colson CreditAttribution: steve.colson commentedLooking at the non-passed tests, I have no idea why the assertFieldByName call is failing, but the supplied patch has nothing to do with the display form. The patch only deals with the creation of the RRULE string that gets stored in the database.
Marking needs reviewed.
Comment #8
steve.colson CreditAttribution: steve.colson commentedRe-rolling against 2.x head