Follow up from #2102777: Allow theme_links to use routes as well as href, we should by now be able to remove this pretty easily. I think anyway...

IIRC it's just the views list controller now that is the issue. Let's try that theory out.

CommentFileSizeAuthor
#10 2136641-10.patch2.4 KBdamiankloip
#5 interdiff-2136641-5.txt806 bytesdamiankloip
#5 2136641-5.patch2.35 KBdamiankloip
vdc.views-ajax-bool-fix.patch2.35 KBdamiankloip
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Parent issue: » #2102777: Allow theme_links to use routes as well as href

trying again to add parent.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Parent issue: #2102777: Allow theme_links to use routes as well as href »

just related, was noticed in that other issue, but existed before.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Related issues: +#2102777: Allow theme_links to use routes as well as href

trying again.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented 
+++ b/core/modules/views_ui/lib/Drupal/views_ui/ViewListController.php
@@ -154,7 +154,8 @@ public function getOperations(EntityInterface $entity) {
+        // Enable and disable  operations should use AJAX.

I think there's a double space there after "disable".

Leaving at needs review.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
FileSize
2136641-5.patch2.35 KB
interdiff-2136641-5.txt806 bytes

Good spot. Thanks!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

I tested the views UI manually and things still work with the nice ajax dialogs. Also enable/disable in the view listing still worked.

There are a bunch of #ajax => TRUE, fapi elements, though these ones are not influenced here:

core/modules/entity_reference/lib/Drupal/entity_reference/ConfigurableEntityReferenceItem.php:142:      '#ajax' => TRUE,
core/modules/entity_reference/lib/Drupal/entity_reference/Plugin/entity_reference/selection/SelectionBase.php:125:        '#ajax' => TRUE,
damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

Yep indeed; I have removed the code in theme_links() in this patch too. I think the entity reference ones are ok though, as they switch it out for an array in process callbacks. So by the time they are rendered they have a regular ajax array in there.

Basically the only real abuse was/is in views UI.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Title: remove boolean usage of ajax property in Views UI link operation building » Remove boolean usage of ajax property in Views UI link operation building

come on me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll 
git ac https://drupal.org/files/issues/2136641-5.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2402  100  2402    0     0   3690      0 --:--:-- --:--:-- --:--:--  4775
error: patch failed: core/modules/views_ui/lib/Drupal/views_ui/ViewListController.php:154
error: core/modules/views_ui/lib/Drupal/views_ui/ViewListController.php: patch does not apply
damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review
FileSize
2136641-10.patch2.4 KB

Rerolled. Conflict was due to the conversion to use the CSRF integration.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

Status: Needs review » Needs work

The last submitted patch, 10: 2136641-10.patch, failed testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review
damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

10: 2136641-10.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

10: 2136641-10.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community
star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Issue tags: -Needs reroll
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 090d5d1 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.