Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem
I updated the AdvAgg module to 7.x-2.1. I now get three new warnings
1. Adv CSS CDN - jquery update Use jquery update instead of this sub module.
The jquery update module has support for CDNs. Go to the jquery update settings page and select a CDN instead of using this module.
2.Adv CSS/JS Agg - gzip Gzip is failing for css files.
The web servers configuration will need to be adjusted. In most cases make sure that the webroots .htaccess file still contains this section "Rules to correctly serve gzip compressed CSS and JS files".
3.Adv JS CDN - jquery update Use jquery update instead of this sub module.
The jquery update module has support for CDNs. Go to the jquery update settings page and select a CDN instead of using this module.
1. It no longer recognizes I'm using Google CDN for jQuery. Clearing the cache and switching the CDN to none and back has no effect. However I'm definitely still downloading the Google API jQuery library. This error is doubled.
2. It says gzip is failing for CSS, however YSlow doesn't list any of my CSS files as being un-gzipped.
Comment | File | Size | Author |
---|---|---|---|
#18 | advagg-2132777-17-test-http-versions.patch | 28.42 KB | mikeytown2 |
#11 | advagg-2132777-11-add-gzip-static-nginx.patch | 694 bytes | mikeytown2 |
#7 | advagg-2132777-7-output-more-info-on-status-report.patch | 3.51 KB | mikeytown2 |
Comments
Comment #1
splitsplitsplit CreditAttribution: splitsplitsplit commentedComment #2
splitsplitsplit CreditAttribution: splitsplitsplit commentedComment #3
splitsplitsplit CreditAttribution: splitsplitsplit commentedComment #4
splitsplitsplit CreditAttribution: splitsplitsplit commentedComment #5
splitsplitsplit CreditAttribution: splitsplitsplit commentedIt seems to have made a comment every time i edited.
Comment #6
mikeytown2 CreditAttribution: mikeytown2 commentedThis is saying that the Adv CSS CDN & Adv JS CDN modules are not needed and should be disabled; they are duplicating the functionality found inside of the jquery update module.
Code for this is check is located here: http://drupalcode.org/project/advagg.git/blob/4b2d913b7fcad9555c9fe8e1b0...
I'll create a patch that will give better diagnostic output when this warning shows up.
Comment #7
mikeytown2 CreditAttribution: mikeytown2 commentedFollowing patch has been committed. If you could apply it (or get the latest dev) and let me know what the gzip warning says that would be helpful.
Comment #8
mikeytown2 CreditAttribution: mikeytown2 commentedComment #9
splitsplitsplit CreditAttribution: splitsplitsplit commentedSorry this has taken so long, I've been having some nginx issues and I had to try and recreate my dev environment.
The warnings are now all updated and useful. I'm getting the following warning in the gzip section.
Other possibly useful bits of information:
I'm running Ubuntu Server 12.04, on a LEMP stack with the default nginx configuration. The relevant lines in my /etc/nginx/sites-available/mysite are below.
I'm new to nginx configuration so it's possible that I've mis-configured it (still learning) however with the chunk below removed or present I still get the gzip error.
Comment #10
mikeytown2 CreditAttribution: mikeytown2 commentedadd
gzip_static on;
to the top of thelocation ~* files/advagg_(?:css|js)/ {
rule block.Comment #11
mikeytown2 CreditAttribution: mikeytown2 commentedFollowing patch has been committed
Comment #12
splitsplitsplit CreditAttribution: splitsplitsplit commentedUnfortunately that has no effect. However turning off Secure pages removes the error. I have the same advagg config below in my secure nginx config. Does HTTPS need a different configuration?
Possibly relevant, I already have gzip enabled in my standard nginx conf: /etc/nginx/nginx.conf
Also when I run YSlow on my page I'm not getting any complaints that anything isn't gzipped. I still have my A rating.
Comment #13
mikeytown2 CreditAttribution: mikeytown2 commentedIf YSlow is giving you an A rating then you're probably good.
Why doing header detection like this isn't 100%:
Requesting your self isn't 100% reliable. Requests will usually take the shortest route to the web server and when you're requesting your self sometimes part of the web stack gets bypassed. I thought about using the Coral Cache as a "proxy" so that requests to your self would go out to the internet and back in so you could get a better gauge on what will actually be seen by a web browser. But requesting things like https://drupal.org.nyud.net/ doesn't work (https) and http://drupal.org.nyud.net/ doesn't show gzip encoding even though http://drupal.org/ is gzip encoded. I haven't come up with a good solution to this problem as it requires a from of an Open Proxy that doesn't modify the headers sent back in order to be 100% effective.
Comment #14
mikeytown2 CreditAttribution: mikeytown2 commentedComment #16
Liam McDermott CreditAttribution: Liam McDermott commentedI had the Gzip is failing for css files. (and for Javascript too) warning messages with nginx, despite my browser showing CSS/JS files were being gzipped. Turned out the problem was nginx was configured to only gzip http 1.1 requests:
Changing this to:
Removed the warnings in my case. I'm marking this issue active again, in case this quirk should be documented somewhere, even if not I thought I'd document this here in the hopes someone else finds it useful!
Apparently configuring nginx to only gzip http 1.1 requests is not just a bad idea for Adv Aggregation, it's also not a good idea if you're using CloudFront CDN.
Comment #18
mikeytown2 CreditAttribution: mikeytown2 commentedIf httprl is enabled and drupal version >= 7.22 AdvAgg will now test http 1.0 & 1.1. Also mentions nginx and points to that article.