I have an issue with the execute function in views_data_export_plugin_display_export being inefficient. Since it calls $this->is_batched() before trying to get the edit from $_GET['eid'], then inside is_batched() it ends up building the query and executing it, which in my case can result in ridiculously inefficient queries. And it is kind of pointless, because if we got the eid before then, then is_batched() would execute very quickly. Patch to follow.

CommentFileSizeAuthor
#1 views_data_export-is_batch_performance-2130619-1.patch1.08 KBbdlangton
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bdlangton’s picture

bdlangton CreditAttribution: bdlangton commented
FileSize
views_data_export-is_batch_performance-2130619-1.patch1.08 KB
bdlangton’s picture

bdlangton CreditAttribution: bdlangton commented
Status: Active » Needs review
greggadsdon’s picture

greggadsdon CreditAttribution: greggadsdon at ComputerMinds commented
Status: Needs review » Closed (won't fix)

As Drupal 6 nears the end of its life and support period, the 6.x version of Views Data Export will not be supported either. To that end, this issue has been closed, and will not be resolved in the 6.x branch of Views Data Export.

If this issue is still relevant to 7.x branch of Views Data Export, then please re-open and move to a relevant 7.x version.