modules/system/system.install:1767: update_variables_to_config('system.menu'

Thanks in advance for helping many hands to make light work!
See #2181257: [meta] Variables to config migration [d7] for instructions

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fastangel’s picture

Assigned: Unassigned » fastangel

working on this.

fastangel’s picture

Status: Active » Needs review

I can't find a variable in D6 to map with the unique variable in d8 active_menus_default

chx’s picture

Title: Variable to config: system.menu » Variable to config: system.menu [D7]
Status: Needs review » Postponed

Please include the name of the variable we are upgrading from. It is not in the issue summary as that's just from a grep update_variables_to_config and because you are not including it I need to look up the name of the variable that you've already looked up.

Ie. the following comment would've been a lot more helpful: I can't find the variable menu_default_active_menus in D6. The D8 variable name is active_menus_default.

Reviewing the functionality, it is indeed D7 only.

eliza411’s picture

Project: IMP » Drupal core
Version: » 8.x-dev
Component: Code » migration system
Assigned: fastangel » Unassigned

Moving to the core queue to consolidate issues now that we're doing all the work there.

eliza411’s picture

Title: Variable to config: system.menu [D7] » Variable to config: system.menu [d7]
Issue summary: View changes
eliza411’s picture

Project: Drupal core » IMP
Version: 8.x-dev »
Component: migration system » Code
Status: Postponed » Active
Parent issue: #2125745: [meta] Variables to config migration [D6] » #2181257: [meta] Variables to config migration [d7]
joshtaylor’s picture

Assigned: Unassigned » joshtaylor
joshtaylor’s picture

Assigned: joshtaylor » Unassigned
David Hernández’s picture

Assigned: Unassigned » David Hernández
David Hernández’s picture

Assigned: David Hernández » Unassigned
Status: Active » Needs review
FileSize
3.24 KB

Hi there,

Here is a first version of the patch with the new test.

Regards,
David.

David Hernández’s picture

FileSize
3.23 KB

Removed whitespaces.

benjy’s picture

+++ b/core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Tests/Dump/Drupal7SystemMenu.php
@@ -0,0 +1,31 @@
+        'name' => 'menu_default_active_menus',
+        'value' => serialize(array('SystemMenu' => 'TestSystemMenuMigration')),
+      ))

These are indented wrong, other than that looks good.

David Hernández’s picture

FileSize
3.23 KB

Fixed issue reported by benjy

benjy’s picture

Status: Needs review » Fixed

Committed to 8.x, I moved the migration into the install folder when I committed it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jcost’s picture

Project: IMP » Drupal core
Version: » 8.0.x-dev
Component: Code » migration system
Status: Closed (fixed) » Needs work

Will need to be submitted again to Core since moving from sandbox.

phenaproxima’s picture

phenaproxima’s picture

Status: Needs work » Closed (won't fix)

The system.menu.active_menus_default configuration setting no longer appears to be a thing in Drupal 8.