6.x-1.10: drupal_strtolower undefined? [#2130319]

Comment #1

William Haller CreditAttribution: William Haller commented 7 November 2013 at 20:13

Also occurs on our site. Reverted to 1.9. The strange thing is drupal_strtolower appears in other modules, although it's possible they aren't in an executed portion. Does just changing it to strtolower do anything for you?

Log in or register to post comments

Comment #2

BigMike CreditAttribution: BigMike commented 7 November 2013 at 20:47

Good to know I am not the only one. I thought about just using strtolower but looking at https://api.drupal.org/api/drupal/includes!unicode.inc/function/drupal_s... there are other parts going on depending on what is sent to the function.

Comparing 1.9 to 1.10, this one line was added, the rest is the same (although "*/autocomplete/*\n*/ajax/*" was removed from the $ignore variable).

Doing some testing now...

Log in or register to post comments

Comment #3

BigMike CreditAttribution: BigMike commented 7 November 2013 at 20:55

Ok, this module is calling that function before the Drupal bootstrap, so the function does not exist.

Solution - at least for now - is to manually invoke unicode.inc by placing a require somewhere above the $path variable, like this:

218:  $ignore = variable_get('securepages_ignore', '');
219:  require_once './includes/unicode.inc';
220:  $path = drupal_strtolower(trim($path, '/'));

Verified this works for me and I completed the site upgrade process without any errors.

BigMike

Log in or register to post comments

Comment #4

sterndata CreditAttribution: sterndata commented 7 November 2013 at 21:14

Will there be another update in the works with corrected code?

Log in or register to post comments

Comment #5

William Haller CreditAttribution: William Haller commented 7 November 2013 at 22:25

Patch works here as well. Thanks.

Log in or register to post comments

Comment #6

gordon CreditAttribution: gordon commented 8 November 2013 at 05:48

Status:

Active

» Fixed

This has been fixed in both 2.x and 1.x.

basically the issue is that securepages_match() is called from securepages_boot() which is before unicode.inc is loaded.

Log in or register to post comments

Comment #7

gordon CreditAttribution: gordon commented 8 November 2013 at 23:21

Status:

Fixed

» Postponed (maintainer needs more info)

I have added changed to both the dev branches, It would be great if you can test this so I can create new releases.

Log in or register to post comments

Comment #8

BigMike CreditAttribution: BigMike commented 9 November 2013 at 23:31

Confirmed 6.x-1.10+2-dev (2013-Nov-08) works just fine!

BTW I have a question. What is the difference between 6-1.x and 6-2.x? It doesn't list any differences on the main project page. I am only using v1.x because when I first began using Secure Pages there was no 6.x-2.x. Should I upgrade? Benefits? Thanks gordon!

Mike