NodeRevisionAccessCheck is still using user_access(), let's replace this with $account->hasPermission(). This is really easy as we already get the account passed into access checks now anyway.

CommentFileSizeAuthor
#2 2129809-1.patch1.4 KBdamiankloip
d8.NodeRevisionAccessCheck-hasPermission.patch1.41 KBdamiankloip
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, d8.NodeRevisionAccessCheck-hasPermission.patch, failed testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
FileSize
2129809-1.patch1.4 KB

Sorry.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

I don't see any kind of problem with this patch. Perfect!

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

2: 2129809-1.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.