The screenshot says it all - the line height results in overlapping characters when an issue title spans multiple lines.

You can see this live at #2127455: The "Update this issue" link is misleading..

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rszrama’s picture

Issue summary: View changes
jonathan1055’s picture

Agree. It is set to 1.2em. Increasing to 1.4em is sufficient - see the screen shot attached.
(oh, I can't attach here, will do that after saving)

jonathan1055’s picture

FileSize
270.18 KB

Showing the change from 1.2em to 1.4em

tvn’s picture

Issue tags: +D.o UX
mgifford’s picture

Status: Active » Needs review
FileSize
472 bytes

so like this.

sun’s picture

Not being aware of the parallel universe of this issue queue, I filed #2194805: Link text overlaps itself in Related issues views block in the Bluecheese queue. :-(

I'd rather recommend to go with this:

/* Fix insufficient line-height for links in related issues block. */
.project-issue-status-info a {
  line-height: 150%;
}

That is, because this is the style from which the offending padding originates from. Hence, that existing style is the style that is responsible for taking care of a potentially wrapped line.

Before vs. After

mgifford’s picture

FileSize
575 bytes

I've got your css up here:
http://search_api-drupal.redesign.devdrupal.org/node/2150405

Looks way better than here:
https://drupal.org/node/2150405

Patch is attached.

EDIT: Thanks for the code @sun!

tvn’s picture

Project: [Archive] Drupal.org D7 upgrade QA » Project issue tracking
Version: » 7.x-2.x-dev

Moving to the proper project for review.

drumm’s picture

Project: Project issue tracking » Bluecheese
Version: 7.x-2.x-dev » 7.x-1.x-dev

Module CSS should be kept minimal, since themers often do not like default styles. This should go into Drupal.org's theme.

I think this would go in either:

  • sass/partials/common/_lists.scss because this is a list.
  • sass/partials/drupalorg/_issue-page.scss because this is on the issue page.
drumm’s picture

Status: Needs review » Needs work