Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The screenshot says it all - the line height results in overlapping characters when an issue title spans multiple lines.
You can see this live at #2127455: The "Update this issue" link is misleading..
Comment | File | Size | Author |
---|---|---|---|
#7 | line-height-2127851-7.patch | 575 bytes | mgifford |
#5 | line-height-2127851.patch | 472 bytes | mgifford |
#3 | related issue line height.png | 270.18 KB | jonathan1055 |
related-issues-link.png | 14.47 KB | rszrama |
Comments
Comment #1
rszrama CreditAttribution: rszrama commentedComment #2
jonathan1055 CreditAttribution: jonathan1055 commentedAgree. It is set to 1.2em. Increasing to 1.4em is sufficient - see the screen shot attached.
(oh, I can't attach here, will do that after saving)
Comment #3
jonathan1055 CreditAttribution: jonathan1055 commentedShowing the change from 1.2em to 1.4em
Comment #4
tvn CreditAttribution: tvn commentedComment #5
mgiffordso like this.
Comment #6
sunNot being aware of the parallel universe of this issue queue, I filed #2194805: Link text overlaps itself in Related issues views block in the Bluecheese queue. :-(
I'd rather recommend to go with this:
That is, because this is the style from which the offending
padding
originates from. Hence, that existing style is the style that is responsible for taking care of a potentially wrapped line.Before vs. After
Comment #7
mgiffordI've got your css up here:
http://search_api-drupal.redesign.devdrupal.org/node/2150405
Looks way better than here:
https://drupal.org/node/2150405
Patch is attached.
EDIT: Thanks for the code @sun!
Comment #8
tvn CreditAttribution: tvn commentedMoving to the proper project for review.
Comment #9
drummModule CSS should be kept minimal, since themers often do not like default styles. This should go into Drupal.org's theme.
I think this would go in either:
sass/partials/common/_lists.scss
because this is a list.sass/partials/drupalorg/_issue-page.scss
because this is on the issue page.Comment #10
drumm