Bean compatibility

Is there an update as to whether this patch will be incorporated into linkchecker? We have tested this locally and it has passed our internal integration and UAT testing. We have patched our production branch with it as we use URL rich beans extensively throughout our site.

I have the same remarks and the same question ! :)

I've used this patch for awhile but found a potential bug today. On line 191 in "_linkchecker_bean_add_bean_links()", the "db_insert()" caused a PDO exception since there was a duplicate bid/lid combo already in there.

Before debugging too much, I thought, "why not change it to db_merge()?" which performs either an insert or update query. I've uploaded my lazy one line change...not doing an interdiff for this. Ought to probably add exception handling, but with db_merge(), I wouldn't be too concerned.

I'm marking this back to needs work since I had a fatal error with it, but feel free to refute me and say it's only me. I'd like this patch to go in since I've only had this issue once.

Okay, here is my non-lazy patch that still works for me. The issue I had is very ephemeral and hard to catch, but adding the merge query and wrapping in a try/catch block seemed appropriate.

screw it, just use the first patch. My issue is with a slave database and using db_ignore_slave() but I doubt you'd want to guard against a slow slave db since most sites don't setup a master/slave configuration.

Just to not confuse anyone - Need to use the patch from #1.
Other (wrong) patches were hidden.

Thank you for contributions. Committed! 🥂