In user_user_role_insert() we create system actions to remove and add the role. This means that we will get unnecessary config conflicts on UUIDs - we should provide defaults.

This change depends on #2127573: Stop creating node, comment and custom block fields automatically and provide defaults in CMI to fully function as this sets the sync flag properly on module install - but this should not affect our tests atm.

Files: 
CommentFileSizeAuthor
#1 2127583.1.patch2.39 KBalexpott
PASSED: [[SimpleTest]]: [MySQL] 60,486 pass(es). View

Comments

alexpott’s picture

Status: Active » Needs review
FileSize
2.39 KB
PASSED: [[SimpleTest]]: [MySQL] 60,486 pass(es). View
alexpott’s picture

vijaycs85’s picture

Looks good to me. +1 to RTBC.

heyrocker’s picture

I think this is great but I expressed some concerns with isSyncing() over in #2127573: Stop creating node, comment and custom block fields automatically and provide defaults in CMI

alexpott’s picture

1: 2127583.1.patch queued for re-testing.

xjm’s picture

Issue tags: +Default configuration
xjm’s picture

Issue tags: +beta blocker
alexpott’s picture

Status: Needs review » Closed (won't fix)

Discussed with yched, heyrocker, xjm, and mtift. We need to be able to support programmatic creation of config entities on install time due to the following scenario:

  1. Enable a contrib module that creates a config entity when a node type is created
  2. Enable a module that creates a node type - there is no way this module can provide default configuration for the contrib module!

Agreed to close this issue in favour of exploring other solutions which will be documented on #2121751: [META] Making configuration synchronisation work

xjm’s picture

Issue tags: -beta blocker