Use case

1. Install Entity Construction Kit and Pathauto Entities modules
2. Create few (at least 2) custom entity types
3. Enable those entity types for use with Pathauto (/admin/config/search/path/entities)
4. On Bulk Update page only one custom entity type is displayed, instead of all created in pt 2.

Issue

#options in $form['update'] form element in pathauto_bulk_update_form() are keyed by batch_update_callback value, which is the same for all entity types created using ECK - which means that regardless how many entity types are created (and enabled to be used with Pathauto), only the last one is displayed in the form.

Proposed solution

Key mentioned #options by keys received from module_invoke_all('pathauto', 'settings') call.

Patch to follow.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

maciej.zgadzaj’s picture

Status: Active » Needs review
FileSize
1.4 KB

Status: Needs review » Needs work

The last submitted patch, pathauto-custom_entities_bulk_generate-2124379-1.patch, failed testing.

maciej.zgadzaj’s picture

Status: Needs work » Needs review
FileSize
2.26 KB

Tests updated now as well, plus key values changed slightly to avoid 0 keys, which break functionality.

maciej.zgadzaj’s picture

FileSize
789 bytes

And by the way (although slightly off-topic), out of my sheer curiosity, is there any specific reason why $settings are not passed to batch's $operations in bulk update? (see attached "patch")