In the Schema report for our site, we show the following allegedly extra fields in the field_rating tables:

field_data_field_rating
field_rating_rating: unexpected column in database
field_rating_target: unexpected column in database

Hidefield_revision_field_rating
field_rating_rating: unexpected column in database
field_rating_target: unexpected column in database

I’m assuming these are cruft from an old implementation of the module. Is that correct? Can I safely delete these fields?

Comments

whiteph’s picture

whiteph CreditAttribution: whiteph commented
Issue summary: View changes

The field_rating_rating column is actively used. I've only seen NULL values in field_rating_target. I suspect bad things would happen if you deleted them.

In fact, the move has been away from Voting API towards the field system - so this isn't legacy cruft. See Loose the hard dependency on votingapi

whiteph’s picture

whiteph CreditAttribution: whiteph commented
Status: Active » Closed (works as designed)
somatics’s picture

somatics CreditAttribution: somatics commented
Status: Closed (works as designed) » Active

So why is the Schema report indicating that those columns are not supposed to be there according to the schema set forth by the module code? Is this a bug in the Schema module instead? Is it a bug in how the Fivestar module reports itself to the rest of the Drupal codebase?

I'm glad to hear the module is working as designed, but it seems like it would be good to also put to rest the reason for the false error reporting.

dbt102’s picture

dbt102 CreditAttribution: dbt102 at BACnet Interest Group - Drupal for BACnet Interest Group - Drupal commented

Please test with 7.x-2.2 release and report back, as there have been a lot of fixes applied since then.