Patch forthcoming for some minor coding standards changes for these files based on Coder's Coder Sniffer.

CommentFileSizeAuthor
#1 views_ticker-Coding_standards_views_ticker_view_tpl-2122603-1.patch3.04 KBfullerja
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fullerja’s picture

fullerja CreditAttribution: fullerja commented
Assigned: fullerja » Unassigned
Status: Active » Needs review
FileSize
views_ticker-Coding_standards_views_ticker_view_tpl-2122603-1.patch3.04 KB 
FILE: .../www/drupal-7-pareview/pareview_temp/includes/views-ticker-view.tpl.php
--------------------------------------------------------------------------------
FOUND 42 ERROR(S) AND 1 WARNING(S) AFFECTING 34 LINE(S)
--------------------------------------------------------------------------------
2 | WARNING | There must be no blank line following an inline comment
2 | ERROR | You must use "/**" style comments for a file comment
2 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
15 | ERROR | The control statement should use the ":" alternative syntax
| | instead of curly braces in template files
17 | ERROR | Spaces must be used to indent lines; tabs are not allowed
18 | ERROR | Spaces must be used to indent lines; tabs are not allowed
20 | ERROR | The control statement should use the ":" alternative syntax
| | instead of curly braces in template files
22 | ERROR | Spaces must be used to indent lines; tabs are not allowed
23 | ERROR | Spaces must be used to indent lines; tabs are not allowed
25 | ERROR | The control statement should use the ":" alternative syntax
| | instead of curly braces in template files
27 | ERROR | Spaces must be used to indent lines; tabs are not allowed
28 | ERROR | Spaces must be used to indent lines; tabs are not allowed
30 | ERROR | The control statement should use the ":" alternative syntax
| | instead of curly braces in template files
32 | ERROR | Spaces must be used to indent lines; tabs are not allowed
33 | ERROR | Spaces must be used to indent lines; tabs are not allowed
36 | ERROR | The control statement should use the ":" alternative syntax
| | instead of curly braces in template files
38 | ERROR | Spaces must be used to indent lines; tabs are not allowed
38 | ERROR | The control statement should use the ":" alternative syntax
| | instead of curly braces in template files
39 | ERROR | Spaces must be used to indent lines; tabs are not allowed
40 | ERROR | Spaces must be used to indent lines; tabs are not allowed
41 | ERROR | Spaces must be used to indent lines; tabs are not allowed
42 | ERROR | Spaces must be used to indent lines; tabs are not allowed
43 | ERROR | Spaces must be used to indent lines; tabs are not allowed
43 | ERROR | The control statement should use the ":" alternative syntax
| | instead of curly braces in template files
44 | ERROR | Spaces must be used to indent lines; tabs are not allowed
45 | ERROR | Spaces must be used to indent lines; tabs are not allowed
46 | ERROR | Spaces must be used to indent lines; tabs are not allowed
47 | ERROR | Spaces must be used to indent lines; tabs are not allowed
48 | ERROR | Spaces must be used to indent lines; tabs are not allowed
48 | ERROR | The control statement should use the ":" alternative syntax
| | instead of curly braces in template files
48 | ERROR | Expected 1 space before "=="; 0 found
48 | ERROR | Expected 1 space after "=="; 0 found
49 | ERROR | Spaces must be used to indent lines; tabs are not allowed
50 | ERROR | Spaces must be used to indent lines; tabs are not allowed
51 | ERROR | Spaces must be used to indent lines; tabs are not allowed
52 | ERROR | Spaces must be used to indent lines; tabs are not allowed
53 | ERROR | Spaces must be used to indent lines; tabs are not allowed
53 | ERROR | The control statement should use the ":" alternative syntax
| | instead of curly braces in template files
53 | ERROR | Perl-style comments are not allowed; use "// Comment" instead
54 | ERROR | Spaces must be used to indent lines; tabs are not allowed
55 | ERROR | Spaces must be used to indent lines; tabs are not allowed
56 | ERROR | Spaces must be used to indent lines; tabs are not allowed
57 | ERROR | Spaces must be used to indent lines; tabs are not allowed
--------------------------------------------------------------------------------
bneil’s picture

bneil CreditAttribution: bneil commented
Issue summary: View changes
Status: Needs review » Needs work

tpl files like these should be primarily html with a sprinkling of php where we need to print variables. Would you be interested in rewriting this?

See https://api.drupal.org/api/views/theme%21views-view.tpl.php/7 for a comparison.

ron_s’s picture

ron_s CreditAttribution: ron_s commented
Related issues: +#2704723: Refactor module

@fullerja, take a look at the tpl.php files in the new patch we've created. I think it's in alignment with what should be expected for Drupal template files.

https://www.drupal.org/node/2704723