Spotted that the setDialogTitle in the OpenDialogCommand didn't work. It is never called which is why I think this hasn't been spotted. Not sure whether this is a bug or a task, but went for bug. Provided a test.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug
Unfrozen changes Unfrozen because it only changes code that doesn't currently work as it is supposed to.
CommentFileSizeAuthor
#22 interdiff.txt2.67 KBSam152
#22 2121119-set-title-dialog-22.patch2.43 KBSam152
#22 2121119-set-title-dialog-22--test-only.patch1.93 KBSam152
#19 2121119-19-do-not-commit.patch1.77 KBBR0kEN
#18 2121119-18.patch2.27 KBBR0kEN
#9 drupal8.ajax_.dialogsettitle-9.patch1.73 KBACF
#6 drupal8.ajax_.dialogsettitle.test.patch1.23 KBACF
#3 drupal8.ajax_.dialogsettitle.test.patch1.22 KBACF
drupal8.ajax_.dialogsettitle.patch1.72 KBACF
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ACF’s picture

ACF CreditAttribution: ACF commented
Issue tags: +London_2013_October

Adding tag.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

Can we get a test-only patch to verify it catches the issue?

ACF’s picture

ACF CreditAttribution: ACF commented
Issue summary: View changes
FileSize
drupal8.ajax_.dialogsettitle.test.patch1.22 KB

Just the test patch.

Status: Needs review » Needs work

The last submitted patch, 3: drupal8.ajax_.dialogsettitle.test.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: drupal8.ajax_.dialogsettitle.test.patch, failed testing.

ACF’s picture

ACF CreditAttribution: ACF commented
FileSize
drupal8.ajax_.dialogsettitle.test.patch1.23 KB

Oops mistake in not using the TestOpenDialogCommand.

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: drupal8.ajax_.dialogsettitle.test.patch, failed testing.

ACF’s picture

ACF CreditAttribution: ACF commented
FileSize
drupal8.ajax_.dialogsettitle-9.patch1.73 KB

This patch now has the same test, but with the fix in the code as well.

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Looks right, and the test passes. I've added the beta phase evaluation to the summary.

jhedstrom queued 9: drupal8.ajax_.dialogsettitle-9.patch for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: drupal8.ajax_.dialogsettitle-9.patch, failed testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented

TestOpenDialogCommand was converted to mocks in #2250165: Replace fake mocks with actual OpenDialogCommand stubs in AjaxCommandsTest.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and at FFW, Drupal Ukraine Community for FFW commented
Status: Needs work » Needs review
FileSize
2121119-18.patch2.27 KB
BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and at FFW, Drupal Ukraine Community for FFW commented
FileSize
2121119-19-do-not-commit.patch1.77 KB

Patch without fixes to ensure test fails.

Status: Needs review » Needs work

The last submitted patch, 19: 2121119-19-do-not-commit.patch, failed testing.

BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and at FFW, Drupal Ukraine Community for FFW commented
Status: Needs work » Needs review
Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
FileSize
2121119-set-title-dialog-22--test-only.patch1.93 KB
2121119-set-title-dialog-22.patch2.43 KB
interdiff.txt2.67 KB

Saw the slack conversation about not mocking the unit being tested. Turns out if the content is a string, the renderer isn't invoked. Also added the assert to the previous test method.

The last submitted patch, 22: 2121119-set-title-dialog-22--test-only.patch, failed testing.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

  • larowlan committed 8b0d7f8 on 8.4.x 
    Issue #2121119 by ACF, Sam152, BR0kEN: setDialogTitle in the...

  • larowlan committed 916e6ba on 8.5.x 
    Issue #2121119 by ACF, Sam152, BR0kEN: setDialogTitle in the...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed as 916e6ba and pushed to 8.5.x.

Cherry-picked as 8b0d7f8 and pushed to 8.4.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.