This issue occured for me in version 7.x-3.6 it also exists in the newest version. I get a notice because the value that I want to show does not exist in the data array of all users.

I think it would be better if the render function checks if the value isset.

Files: 
CommentFileSizeAuthor
#6 views-serialized-check-value-isset.2120243-4.patch751 byteswillembressers
PASSED: [[SimpleTest]]: [MySQL] 1,627 pass(es). View
#5 views-serialized-check-value-isset.2120243-4.patch769 bytesericclaeren
PASSED: [[SimpleTest]]: [MySQL] 1,627 pass(es). View
#3 views-serialized-check-value-isset.2120243-1.patch692 bytesJohnny vd Laar
PASSED: [[SimpleTest]]: [MySQL] 1,627 pass(es). View
#1 views-serialized-check-value-isset.2120243-1.patch820 bytesJohnny vd Laar
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-serialized-check-value-isset.2120243-1.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

Johnny vd Laar’s picture

Status: Active » Needs review
FileSize
820 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-serialized-check-value-isset.2120243-1.patch. Unable to apply patch. See the log in the details link for more information. View

Here is a patch.

Status: Needs review » Needs work

The last submitted patch, views-serialized-check-value-isset.2120243-1.patch, failed testing.

Johnny vd Laar’s picture

Status: Needs work » Needs review
FileSize
692 bytes
PASSED: [[SimpleTest]]: [MySQL] 1,627 pass(es). View

oh

ericclaeren’s picture

Mr Johnny, I have a improvement for the patch, you checked a string and not the keys in the serialized array, so the problem still exists.

I have attached an updated patch on 7.x-3.7

ericclaeren’s picture

Issue summary: View changes
FileSize
769 bytes
PASSED: [[SimpleTest]]: [MySQL] 1,627 pass(es). View
willembressers’s picture

FileSize
751 bytes
PASSED: [[SimpleTest]]: [MySQL] 1,627 pass(es). View

Patch #5 had no fallback if the if statement fails.

I've created a patch which checks the keys and returns a plain version or an empty string (which in case can be handled with the "no results behaviour" option).

francois o’s picture

Running into this issue: #6 works for me