Problem/Motivation

Currently most of the test form controller implements formInterface. Since there is no common base class, formController need to take care of all supporting methods injection, etc( e.g. t() vs $this-t()

Proposed resolution

Discuss and find what is the best way to handle this. Either we can use Drupal\Core\Form\FormBase.php or we can have test specific formBase.

Remaining tasks

1. Discussion
2. Document
3. Patch, if it is a new formBase.

User interface changes

No

API changes

No

Follow-up from #1987606-20: Convert ajax_test_dialog() to a new style controller

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Closed (works as designed)

Just had a chat with @alexpott on IRC.

17:46 alexpott: vijaycs85: https://drupal.org/node/1987606 I don't get why AjaxTestDialogForm is not just extending FormBase
17:46 alexpott: vijaycs85: and why this even needs discussion https://drupal.org/node/2116145
17:48 vijaycs85: alexpott: I created this because I thought we would have something specific to test
17:48 vijaycs85: alexpott: the same way we use $this->container
17:51 vijaycs85: alexpott: https://drupal.org/node/2120459#comment-8003479
17:52 alexpott: vijaycs85: I think we can just use FormBase and move on
17:53 vijaycs85: alexpott: sure, I will update the issue and close