Numbers are displayed in search results list

Actually, Stark has the same problem. Maybe we should solve this in a search.module CSS file?

We are planning to remove search-results.html.twig in this other issue:
#1926344: Consolidate search-result.html.twig and search-results.html.twig
so we should probably postpone this issue.

The other issue is long-since resolved, so this one can be un-postponed now. Markup is different.

RE #13, that is a very good question.

The search results page is built in \Drupal\search\Controller\SearchController::view(). It looks like in 8.x it is still possible to attach CSS file to a render array, so we should be able to put it in '#attached' as a library in $build['search_results'] or $build.

And looking at that previous patch... Libraries are not added with hook_library_info() any more, it looks like, but instead would go into a search.libraries.yml file. See change notice:
https://drupal.org/node/2201089
And it does look like making a library is the Drupal Way to attach CSS.

There is a CSS-only library YAML file example in core/modules/forum/forum.libraries.yml that should be useful to follow, although it looks like according to https://drupal.org/node/1887922 that we should put our CSS file into key "theme", not "component", since this is purely visual styling.

Hope that's enough to go on!

This patch looked pretty good to me, but I tested it and it doesn't actually work.

I looked at some other uses of ['#attached']['library'] in Core and they look like this:

filter/filter.module:  $element['#attached']['library'][] = array('filter', 'drupal.filter');

while this patch had:

+    $build['#attached']['library'][] = 'search/drupal.search.results';

When I changed the string at the end to array('search', 'drupal.search.results'), then it worked.

Also, there is extra whitespace on the line just before that.

So... Here is a new patch -- no interdiff, this is a small patch and both of the lines in SearchController changed (all else is the same). And here are some before/after screen shots:
Before (taken when I first filed this issue):

After (taken with different nodes in the DB with this new patch applied):

longwave: you're right. I forgot, I haven't done a pull on my repo recently. :(

OK, we need to skip the patch in #16 (I'll hide the file) and test the patch in #15 on a more recent install.

OK, now the patch in #15 works for me. It still has some trailing whitespace in the Controller section.

So here is a trivial redo of #15 without the extra spaces on that line. I will venture to go ahead and mark it RTBC since I have now verified that it works and longwave also looked at it.

Back to RTBC after random test failure.

I do not think that this applies when the CSS is included in a Library, which is what is done in this patch. We don't need that CSS file to be loaded on every page -- only on search results pages. Putting it in a library achieves that. I believe that if we put it into search.theme.css it would get loaded on every page.

This may not matter much, since there are only a few lines of CSS here... Maybe we can get someone involved in the theme system to comment?

Thanks for clarifying! In that case, we should change the file name. The libraries thing is still necessary. Thanks!

Thanks!

Confirmed this is exactly the same as the previous patch, with the file name change requested by webchick.

Also confirmed the patch works to remove the numbers on search results.

Let's get it in this time. :)