which i find weird tbh.
i think though we should add it as dependency.

CommentFileSizeAuthor
#6 file_entity-token-2114793-6-do-not-test.patch6.5 KBParisLiakos
#6 interdiff.txt4.34 KBParisLiakos
#3 file_entity-token-2114793-2.patch2.16 KBParisLiakos
#3 interdiff.txt1.39 KBParisLiakos
#1 file_entity-token-2114793-FAIL.patch915 bytesParisLiakos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Active » Needs review
FileSize
file_entity-token-2114793-FAIL.patch915 bytes

a test that demonstrates the failure

Status: Needs review » Needs work

The last submitted patch, file_entity-token-2114793-FAIL.patch, failed testing.

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.39 KB
file_entity-token-2114793-3.patch2.16 KB

so lets add token as dependency

Status: Needs review » Needs work

The last submitted patch, file_entity-token-2114793-2.patch, failed testing.

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs work » Needs review

yes, of course it failed because bot does not checkout the token module
locally the test passes

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
FileSize
interdiff.txt4.34 KB
file_entity-token-2114793-6-do-not-test.patch6.5 KB

lets get rid of the module_exists calls too

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll

The 5 year old patch in #6 does not apply to the latest file_entity 7.x-2.x-dev and if still relevant needs a reroll.