Cannot redeclare registry_rebuild_* [#2114717]

By committing Registry Rebuild into the distro (as per https://drupal.org/node/1983606#comment-7788313), any person who has Registry Rebuild installed the correct way (in their .drush folder) will receive errors about redeclaring registry_rebuild_* functions when running Drush, which for users installing a site into Commons via Aegir means that they can not install said site at all.

Work around is to have the user remove or move their local copy of Registry Rebuild, but it's not really a nice solution.

Patch coming to remove the entry from the makefile.

Comment	File	Size	Author
#2	registry_rebuild-2114717-2.patch	647 bytes	Devin Carlson
#1	registry_rebuild-2114717-1.patch	1.66 KB	Deciphered

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Deciphered CreditAttribution: Deciphered commented 17 October 2013 at 23:06

Status:

Active

» Needs review

File	Size
registry_rebuild-2114717-1.patch	1.66 KB

Patch removes the makefile entry and wraps the hook_update_N() function with a conditional, as well as making a note that there should probably be more work done before (if) this is to be committed as in the case a user doesn't have Registry Rebuild they should be prompted to download and run it.

I understand this isn't the best solution, but breaking drush for someone isn't that good either.

Comment #2

Devin Carlson CreditAttribution: Devin Carlson commented 18 October 2013 at 15:18

Version:

7.x-3.4

» 7.x-3.x-dev

File	Size
registry_rebuild-2114717-2.patch	647 bytes

I agree that having a duplicate copy of Registry Rebuild can be a pain and storing it outside of your .drush folder is not best practice.

As a note, commons_update_3106() calls registry_rebuild() which is a function defined in includes/bootstrap.inc, not drush_registry_rebuild() which is a function provided by the Registry Rebuild module.

I believe the best approach would be to remove the Registry Rebuild module and mention in the documentation that, should your site get hosed or if the update fails for some reason, to download and use the Registry Rebuild module to fix your site externally.