Rename \Drupal\Component\Plugin\PluginBag::addInstanceID() to addInstanceId() for consistency with our coding standards.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xano’s picture

Assigned: Xano » Unassigned
Status: Active » Needs review
FileSize
2.86 KB
Xano’s picture

FileSize
4.21 KB

This patch also renames \Drupal\Component\Plugin\PluginBag::removeInstanceID() to removeInstanceId()

tstoeckler’s picture

Title: Rename \Drupal\Component\Plugin\PluginBag::addInstanceID() to addInstanceId() » Rename \Drupal\Component\Plugin\PluginBag::*ID(s)() to *Id(s)()

Can we also do getInstanceIDs and setInstanceIDs here?, I think that would make sense.

Xano’s picture

Assigned: Unassigned » Xano
Xano’s picture

Assigned: Xano » Unassigned
FileSize
5.94 KB
tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community

Awesome, thanks.

Xano’s picture

#5: drupal_2113337_5.patch queued for re-testing.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)
Issue tags: +

Automatically closed - issue fixed for 2 weeks with no activity.