Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Updated: Comment #0
Problem/Motivation
Image effects have a base form that is extended by an add form and an edit form, but the forms do not implement BaseFormIdInterface. Therefore it is currently impossible to alter the 'add' or 'edit' forms specifically, you can only alter both at the same time.
Btw, this issue was generally larger scoped, but it turned that image effects are the only forms in core that are currently not using BaseFormIdInterface when they should. I had found that by chance and had assumed that there would be more, but there isn't. :-)
Proposed resolution
Make ImageEffectFormBase implement BaseFormIdInterface.
Remaining tasks
User interface changes
API changes
Related Issues
Comment | File | Size | Author |
---|---|---|---|
#3 | 2113089-3.patch | 2.38 KB | tstoeckler |
#1 | 2113089-1.patch | 2.38 KB | tstoeckler |
Comments
Comment #1
tstoecklerSee the issue summary for the new title :-)
Comment #3
tstoecklerAhh, the getFormID() -> getFormId() change...
Comment #3.0
tstoecklerUpdated issue summary, this only affects image styles...
Comment #4
tstoecklerComment #7
tim.plunkettAs much as I disagree with the forced splitting of every form, I think that is a better option than using BaseFormIdInterface
See #2324871: Split ForumForm into ForumAddForm and ForumEditForm and similar