Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is in-line with what's being done in core and also makes sense in general as it allows to get rid of the pesky if ($action == 'edit')
and similar checks.
Comment | File | Size | Author |
---|---|---|---|
#11 | 2111087-11.patch | 38.42 KB | Gábor Hojtsy |
#11 | interdiff.txt | 1.99 KB | Gábor Hojtsy |
#9 | 2111087-9.patch | 36.43 KB | Gábor Hojtsy |
#9 | interdiff.txt | 2.02 KB | Gábor Hojtsy |
#8 | 2111087-8.patch | 36.03 KB | Gábor Hojtsy |
Comments
Comment #1
tstoecklerBtw, including #2111013: Site information is displayed in the wrong language on the site information translation page in this one, as the same code will be touched.
Comment #2
tstoecklerHere we go.
Comment #4
tstoecklerWell, that was only minimally smart of me... :-(
Oops, just realized the weird filename in #2. Interdiff and new patch should still be fine, though (and correctly named).
Comment #5
tstoecklerIs this my brain telling me to go to bed?
Weird, though, that this didn't fail locally.
Comment #6
tstoecklerlater in the *request*
Comment #7
tstoecklerNice, so this passed. I won't reroll for #6, though.
Since this still includes #2111013: Site information is displayed in the wrong language on the site information translation page it will need to be rerolled anyway once that is in.
@Gábor Hojtsy: Or if you want to commit the two together (i.e. this patch directly) maybe you can fix the comment pre-commit?!
I don't really care.
Comment #8
Gábor HojtsyRerolled after #2111013: Site information is displayed in the wrong language on the site information translation page landed.
Comment #9
Gábor HojtsyRolled in separate messages as discussed in #2110491-19: Modernize and clean-up controller and forms.
Comment #11
Gábor HojtsyWith fix for tests, now testing separate messages as well.
Comment #12
tstoecklerAwesome, I totally forgot about that!
The interdiffs are RTBC if this comes back green. Since this isn't core, marking the whole patch RTBC as well :-)
Comment #13
Gábor HojtsyYay, committed! Thanks a lot again!
Comment #14
Gábor HojtsyBTW hook_menu() for routing was recently removed in #2106709: Remove legacy router backward compatibility layer, so now its only used for other things, and we only use it for contextual links, since there is no replacement yet (#2084463: Convert contextual links to a plugin system similar to local tasks/actions for that). So I'm not sure we are limited in terms of deepness in menus anymore(?). Re the hook_menu() limitation mentioned in the commit :)
Comment #15
tstoecklerWell the contextual links are the ones that hit the parent limit, right? I.e. the contextual links on some fields or something if I remember correctly. So I think we need to wait on #2084463: Convert contextual links to a plugin system similar to local tasks/actions. But I didn't actually try it out, it might be that this actually works already. :-)
Comment #16
Gábor HojtsyYeah maybe. Did not try it either :)