I'm coming here from #2109773: jquery update breaks date picker

The issue is actually the jquery.timeentry breaking. I did some local testing and the 1.5.2 works great with Drupal Core without jquery_update and with jquery_update with all versions of jquery including (1.5, 1.7, 1.8, 1.9, and 1.10).

Fixed coming right up.

CommentFileSizeAuthor
#1 date.date-popup.2111071-1.patch29.32 KBericduran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ericduran’s picture

Status: Active » Reviewed & tested by the community
FileSize
29.32 KB

This is a patch from git format-patch as some files where rename to make the project accordingly.

Use git am to patch accordingly.

Thanks.

cafuego’s picture

Status: Reviewed & tested by the community » Needs review

Popping the issue back to Needs review, because you're not allowed to put your own issues on RTBC :-)

vijaycs85’s picture

+++ b/date_popup/themes/jquery.timeentry.css
@@ -1,8 +1,5 @@
-vertical-align: middle;
-margin-left: 2px;
-}
-* html .timeEntry_control { /* IE only */
-margin-top: -4px;
+  vertical-align: middle;
+  margin-left: 2px;

Seems not related to this issue or new version doesn't need IE fix?

ladybug_3777’s picture

Issue summary: View changes

What is the status of this issue? The patch (as stated by the author) is written with git am, which I'm unfamiliar with so I'll need to do a little googling to see how that effects the way I would apply the patch within my custom .make files. Also has anyone else tested this and can report on how well it worked out (or will I be the first one to leave feedback?).

Status: Needs review » Needs work

The last submitted patch, 1: date.date-popup.2111071-1.patch, failed testing.

cafuego’s picture

Status: Needs work » Closed (works as designed)

I just had a look at in the latest 7.x-2.x version of date and the included version is already Time entry for jQuery v1.5.2. Have a look at http://cgit.drupalcode.org/date/tree/date_popup/jquery.timeentry.pack.js. Fixed in #1997774: Update Time Entry plugin to 1.5.2.

So I'm closing this issue.

If that bit of CSS needs changing, please re-open the issue or make a new issue.