Updated: Comment #1
Problem/Motivation
When you have translated the site information (site name, slogan) and go to edit that translation, the *actual* site name and slogan are displayed translated, even if the actual admin page that you're on is an English one. I.e. you are on example.com/admin/... not example.com/de/admin/..., for example.
I can think of two possible reasons for this:
A: The language negotation system checks for the "langcode" query parameter (the actual url is e.g. http://drupal-8.loc/admin/config/system/site-information/translate?action=edit&langcode=de
). That should not happen, though.
B: During the creation of the translation form the language configuration context is entered at some point, but never left, so when the site name part of the site does its $config->get() the language context ist still active and thus returns the translated values.
Steps to reproduce
- Install Configuration Translation module
- Create at least one additional language (URL:
admin/config/regional/language
) - Go to the site information form (URL:
admin/config/system/site-information
) - Click on the Translate settings tab and add a translation in the newly added language
- After saving the translation, go to edit it again
Proposed resolution
Remaining tasks
User interface changes
API changes
Related Issues
Comment | File | Size | Author |
---|---|---|---|
#6 | 2111013-6.patch | 2.82 KB | tstoeckler |
#4 | 2111013-4.patch | 2.07 KB | tstoeckler |
#1 | german-override-sticks.png | 116.47 KB | tstoeckler |
Comments
Comment #1
tstoecklerHere's a screenshot of the broken behavior.
Comment #1.0
tstoecklerWrap the long URL in < code > as it is being trimmed.
Comment #1.1
tstoecklerEmbedding the screenshot from #1 in the issue summary
Comment #1.2
tstoecklerUpdated issue summary.
Comment #2
Gábor HojtsyIt may indeed be that the context is not left...
Comment #3
tstoecklerYes, I think I found the problem as well. Am just writing tests for this, currently.
Comment #4
tstoecklerHere's a tests-only patch.
Comment #6
tstoecklerNicely fails on the exact right assertions. Here's one with a fix. *crossing fingers*
(Not providing an interdiff, because it seems sort of pointless)
Comment #7
Gábor HojtsySuperb, thanks!
Comment #8.0
(not verified) CreditAttribution: commentedAdded detailed steps to reproduce