Updated: Comment #0

Problem/Motivation

If you create a custom date-format and then try to edit it without changing the format, you receive an error 'This format already exists. Enter a unique format string.'

Proposed resolution

Fix it

Remaining tasks

Review

User interface changes

None

API changes

None

Test patch coming

CommentFileSizeAuthor
#8 date-format-edit-2110777-8.patch2.18 KBherom
#8 interdiff-2110777-6-8.txt929 bytesherom
#6 interdiff.txt1.81 KBlarowlan
#6 date-format-edit-2110777.2.patch2.21 KBlarowlan
#5 interdiff.txt915 bytesherom
#5 date-time-fail-5.patch1.33 KBherom
#5 date-time-pass-5.patch2.18 KBherom
#2 date-time-pass.patch2.18 KBlarowlan
#1 date-time-fail.patch1.33 KBlarowlan
#1 date-time-pass.patch1.33 KBlarowlan

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
StatusFileSize
new date-time-pass.patch1.33 KB
new date-time-fail.patch1.33 KB

Something like this.
Simpletest playing up locally so hoping for red/green but could be wrong

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new date-time-pass.patch2.18 KB

Wrong patch for .pass

Status: Needs review » Needs work

The last submitted patch, date-time-pass.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented 
+++ b/core/modules/system/lib/Drupal/system/Form/DateFormatFormBase.php
@@ -197,7 +197,7 @@ public function validate(array $form, array &$form_state) {
+      if ($format->getPattern() == $pattern && $format->id() != $this->entity->id()) {

will probably need a check for isNew() too

herom’s picture

herom commented
Status: Needs work » Needs review
StatusFileSize
new date-time-pass-5.patch2.18 KB
new date-time-fail-5.patch1.33 KB
new interdiff.txt915 bytes

new patch.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new date-format-edit-2110777.2.patch2.21 KB
new interdiff.txt1.81 KB

Includes #4

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented 
+++ b/core/modules/system/lib/Drupal/system/Tests/System/DateTimeTest.php
@@ -96,6 +96,13 @@ function testDateFormatConfiguration() {
+    $this->assertEqual($this->getUrl(), url('admin/config/regional/date-time', array('absolute' => TRUE)), 'Correct page redirection.');

This can be assertUrl(), right?

Otherwise this is great.

herom’s picture

herom commented
StatusFileSize
new interdiff-2110777-6-8.txt929 bytes
new date-format-edit-2110777-8.patch2.18 KB

#7 done.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

as per #7

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 885ac82 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.