Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I found a few cases where the docblocks for Drupal\Core\Database were incorrect. Specifically there were many functions that didn't call out the proper namespaces for the exceptions that were being thrown. This fixes that.
Comment | File | Size | Author |
---|---|---|---|
DocblockDatabase.patch | 1.27 KB | cosmicdreams | |
Comments
Comment #1
dawehnerIt seems to be for me that there should be some comment when these exceptions are thrown.
Additional: new line between @throws and @return needed
Comment #2
cosmicdreams CreditAttribution: cosmicdreams commentedYea you're right. I'll do my best to explain why the exceptions would be thrown this weekend.
Comment #3
BerdirAlso, I think @throws comes after @return?
Comment #4
cosmicdreams CreditAttribution: cosmicdreams commentedFixing the status, this clearly needs work.
Comment #13
quietone CreditAttribution: quietone as a volunteer commentedThere are two changes in the patch. One has been done in #2342521: Docblock fixes for core/lib/Drupal/Core/Database/Connection.php and the other is in #2941148: Fix Drupal.Commenting.FunctionComment.MissingReturnType.
Therefore, closing as a duplicate, adding credit in the latter issue. If that is wrong, reopen the issue, by setting the status to 'Active', and add a comment.
Thanks!