Google provider does a strict comparison to "on", core does a comparison and sets a global variable based on a lower-cased $_SERVER['HTTPS'] value.

Attached patch swaps out the redundant logic to lean on core HTTPS detection.

CommentFileSizeAuthor
#7 2109435-google-fonts-with-update.patch2.31 KBdjdevin
#4 2109435-google-fonts-https-2.patch2.05 KBkyletaylored
#1 fontyourface.https_detection.patch.txt824 bytesaidanlis
fontyourface.https_detection.patch901 bytesGrayside
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aidanlis’s picture

aidanlis CreditAttribution: aidanlis commented
Issue summary: View changes
FileSize
fontyourface.https_detection.patch.txt824 bytes

We don't even need HTTPS detection, use // instead.

Grayside’s picture

Grayside CreditAttribution: Grayside commented

I'm pretty sure I tried that and it failed somehow.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented

3 years later...

Patch in #1 worked.

Example when using OpenShift, some container platform or a CDN, Drupal is going to be responding on a non-SSL configuration and the SSL is going to be on the router side so Drupal won't know it is in SSL mode other than the base_url. Best to use the schema neutral URL.

kyletaylored’s picture

kyletaylored CreditAttribution: kyletaylored at FFW commented
Related issues: +#2901275: https detection on Acquia
FileSize
2109435-google-fonts-https-2.patch2.05 KB

This issue was fixed in 8.x, and really just needs to be rolled back into 7.x.

I've attached a patch that rolls in the 8.x commit, in addition fixes the project URL (since it no longer exists).

sdowney2002’s picture

sdowney2002 CreditAttribution: sdowney2002 as a volunteer commented

#4 works. Can we PLEASE get this committed?

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs review » Reviewed & tested by the community
djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
FileSize
2109435-google-fonts-with-update.patch2.31 KB

This also requires an update hook, otherwise existing fonts will not work.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Reviewed & tested by the community » Closed (outdated)
TrevorBradley’s picture

TrevorBradley CreditAttribution: TrevorBradley commented

Patch #7 worked great - desperately needed it for our K8s setup. This is definitely not outdated, the fault still exists in the latest release (unless there's another issue which has patched it into dev)